solved my custom jrXCommentDelete module stopped working

As a made-up example, a longtime ongoing a group discussion like maybe "What are you working on Today?" that has accumulated over 700 posts, I might click the option to delete all posts older than 180 days. It would delete those older posts (which are actually 'comments') and a popup would then tell me how many posts were successfully deleted.
Now no matter what time option i choose, the screen refreshes but nothing happens.
I think this effects all the features that I checked as Active active for this CommentDelte module, not just Group Discussions. (such as Image, Youtube, Event, Gallery, Profile, Forum....)

It's tough to test, because I only can test it on things i don't mind deleting.. !
In one test however, it did delete a few dozen most recent posts.. and i restored them from my recycle bin before testing further.


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
updated by @strumelia: 12/21/20 08:24:39AM

don't delete anything else, we'll take a look at the module's code. something may have changed.

Hi Strumelia
I'm not seeing any issue on my test site or your site.
I logged into fotmd as both admin and as a user, created test images, added comments and deleted them using the custom module. I also altered the database of the test comments to be older than 7 days and deleted them with that option.
Can you maybe try it again, and if these issue persists, let me know specifically the item and the comment delete module option?
Thanks


--
Paul Asher - JR Developer and System Import Specialist

Paul, I think you have my Admin login to Fotmd.com. I got the module to successfully work in one discussion in this (private) admin group, but not in this other discussion:
https://fotmd.com/strumelia/group_discuss/2725/moderators-chitchat
That discussion has 668 replies (comments). As master damin, I try to use the module to remove all comments in it older than 180 days (doesn't work), then i try 90 days, finally i try 30 days,... and I still have 668 replies in the discussion. I've tried a browser hard refresh, clear cache, and also an integrity check after these attempts, but nothing changes.
Occasionally, I get an error popup when i try, saying: "FOTMD.com says: undefined". But mostly when i click to go ahead and delete some posts, the screen refreshes and and nothing has changed.
It used to be I'd get a message telling me how many replies were deleted, but i never get that message now, even on the occasion when it does delete some older comments.
This is on win10 on chrome, btw. I'll try it out on Firefox now and report back here.


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
updated by @strumelia: 09/10/20 09:46:56AM

Ok, I just tried to trim comments in that same discussion from Firefox. With both the 90 day and 30 day options, I get this popup: "No comments older than 30 (or 90) days found". I don't get that message in chrome. But the trouble is that discussion has PLENTY of comments older than those options.


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

See my above two posts for example of where I'm having this issue. Thanks!


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

Sorry for the delay. I've just tried the 30 day option on that group discussion and 30 items were deleted. Have looked at the item and the oldest comment is 08/16/20 so it looks about right?


--
Paul Asher - JR Developer and System Import Specialist

Paul, something's not quite right.
In that "moderator's Chitchat" thread, I do see that the oldest comment is now from Aug 16. I continued clicking on "show more" comments until there was no more 'show more' link, indicating that was the end of the comments- I then counted them all by hand from 8/16 til today and it's in the neighborhood of 120 comments. However, on the Group's Main page it continues to show that there are 659 comments in that discussion.
This is the problem- for me it not only has completely stopped telling me how many comments have been deleted, but I also am no longer able to see an accurate count of comments.
Over the past couple of weeks no matter how many times i've tested deleting comments, the indicated count for that discussion remains somewhere in the 600 range. And it never tells me anymore whether it has deleted any comments or not, or how many.


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

I think this is likely a bug. I’ll check it out tomorrow and let you know.


--
Paul Asher - JR Developer and System Import Specialist

I have this fixed. For some reason your GroupDiscuss comment counts are out of sync (probably some historical bug) so have added a tool to the Comment module to check and update the values on all GroupDiscuss (and other) datastore items. This will be in the next release of the Comment module but have updated your site with it now and have run it (just on the GroupDiscuss module).
Let me know if it all now looks ok (or not).
Thanks


--
Paul Asher - JR Developer and System Import Specialist

Thanks Paul!
I'm still seeing aproblem. I ran integ check, hard refresh, etc etc.
In that private Mod group, look at the "Should We Do Something About..." discussion- it still says there are over 300 comments in it, but I've run the 90 days delete on it from both Chrome and FF, and now i manually count about 42 comments remaining... but again it still says over 300, ...........and also in Chrome it does not tell me if or how many comments it deletes (like it used to so nicely). I think in FF it is at least telling me how many comments it deletes.


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

After running rebuild counts tool, clear any caches.

Also, I'm not seeing and issues with it telling me how many comments were deleted with either FireFox or Chrome.


--
Paul Asher - JR Developer and System Import Specialist

Where is the Rebuild Counts Tool? I don't see any Tools tab in the Comment Delete custom module. ?


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

Its in the Comment module.


--
Paul Asher - JR Developer and System Import Specialist

Note that I have run this tool for Group Discussions and reset the caches so it should be go to go now.


--
Paul Asher - JR Developer and System Import Specialist

Duh! lolol Thanks Paul.
As long as the count can be accurate I guess I don't really need the module to tell me how many comments it deleted (maybe that's a popup setting in my Chrome or something, who knows).

Since you put in a fix on the next Comments Module release, I'm guessing it's not due to a custom template override of mine, correct? And if that's true, then it'll automatically get fixed at that point on my other pennywhistle site without my doing anything, right? (the whistle site is mostly a test site so is not important at all to fix up right now).


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

The custom module decrements the comment counts by the number deleted and this is working. Your problem was that the count was wrong in the first place. Not sure why that was, but we now have a tool to make things right, should you suspect it has happened elsewhere.
So, nothing to do with your customised templates
Will get the new Comment module released to the Marketplace asap.


--
Paul Asher - JR Developer and System Import Specialist

No need to rush about getting the module rushed to marketplace.
Thank you for answering my additional questions, and for fixing this up.


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015