solved Need to tweak a customization of Index/main page Timeline "comments".

Hi,
This is in reference to the skin customization I've had for a long time now, as detailed here when i lost it once before:
https://www.jamroom.net/the-jamroom-network/forum/my_posts/48816/recovering-a-small-skin-customization-i-lost-when-i-moved-to-jr6#last

The customization in question is for the main page timeline/activity feed... I prevent profile page 'comments' from showing up on the main page activity feed, because it's too awful to see like 8 posts in a row of "Hi there!"/"welcome to the site!"/"You'll have fun here!"/"Welcome!" ... every day and so on. (I have a team of 'welcomers' who greet every new member).
So look- the customization IS STILL WORKING fine on my site's main page ... when a member is LOGGED IN.
Here's what it looks like when someone is LOGGED IN, and this is how i LIKE it:



--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
updated by @strumelia: 09/11/17 02:11:27AM

The recent problem ever since the latest module updates is:
When members are LOGGED OUT, or for non-members who come to check out my site before joining, they see all the many many 'welcome comments' and it looks like THIS, which is awful:


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

In conclusion, my tweak to the site's main page activity feed is working, but somehow lately is no longer working for logged OUT members or non-members. A while back, it used to work whether logged in or not logged in.
I need to find where/how to fix it so it prevents those profile comments from showing up also for logged OUT.


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
updated by @strumelia: 06/09/17 02:44:42PM

I've been testing this here this morning and am unable to reproduce this on 6.1, so my feeling is this is likely already fixed. When I get some time this coming week I will see if I can confirm that by putting some debug in on your system and let you know.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

Brian, sorry- I've narrowed the issue down further after more experimenting-

So far have tested on Chrome and Safari, on both iPad and win PC, with the same results for all below:

All is appearing well when logged in as a Master Admin (I have my own login, and a test MasterAdmin).

Profile comments are showing (which they should NOT) on the Home page timeline when one is either logged OUT, or when logged in as a regular member or also as a ProfileAdmin. (this on both iOS and Windows, with both safari and Chrome) Have not tested FF yet, but would expect the same.

You may have to scroll back a few hours to find a 'welcome to the site' type profile comment, since have not had any new members today yet.

If you need some login credentials for testing under different quotas, let me know and I can send them to you, or I could open a ticket to get them to you. Thanks!

update: interestingly, this issue is happening only on my FOTMD site, not on my Pennywhistleclub site, where all continues to be as it should be. Not sure why the difference, since I've been updating them both equally the same for months.


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
updated by @strumelia: 06/10/17 10:21:34AM

This is not browser related, so you can save time an not worry about checking on different browsers.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

I checked it out yesterday too, but could not see a solution, it should be working. One thing I would ask you to check @strumelia is a regular users account. It seemed to me the same results were coming back for logged out users AND regular users and that only ADMIN users were getting the expected results. could you see if that is what you see please.

Yes I did test it on both sites using test members in all three quotas, also when logged out.

Michael, yes i did that already- as per my post above:
"All is appearing well when logged in as a Master Admin (I have my own login, and a test MasterAdmin).
Profile comments are showing (which they should NOT) on the Home page timeline when one is either logged OUT, or when logged in as a regular member or also as a ProfileAdmin. "

What I can't figure out is why everything is working fine on my other Pennywhistleclub site, which has had all the same updates... but on my main FOTMD site it used to all work fine too- until recently... perhaps after the last large set of updates?
Just about everything i tweak on one site, I apply to the other, because I like how I have things set up.


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
updated by @strumelia: 06/11/17 08:33:39AM

I believe we have this fixed for the next Core release. It's in a very tricky area that has to do with optimization of sub queries when there are datastore items that could be missing custom keys. I have tested here and don't see the issue, but Michael was able to replicate it and I have a fix in that Michael says has fixed it for him.

So that will be out in the next Core beta (6.1.0b4).


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

Thank you- is there any way to find out why the problem is happening on my FOTMD site but problem not happening on my Pennywhistle site without combing through 'everything'? I was pretty sure I have them both set up the almost the same, and that both were working fine until recently. If I knew the difference then perhaps the Pennywhistle site setting/code difference could be applied to fix the FOTMD site. (I'm still on core version 6.0.7)


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

I'll have to manually add the changes in to your site. I'll do that and let you know.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

I have made the changes - let me know if that looks better.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

Brian, your fix seems to be working well! I tested it on my fotmd site, and i assume you did nothing to the pennywhistle site because it had not been an issue there.

Thank you very much!
One question though- will I need to adjust or revert anything concerning this fix you made, when i eventually move to core 6.1.0 ?


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

pretty sure you wont have to. brian will have made the changes needed to add the fix to your current version, then when the new version comes out it will have the fix in it so you wont have to do anything.

Just double checking it now to make sure it is working as I thought it was yesterday.

--edit--
After double checking, its all still looking correct today.
updated by @michael: 06/11/17 07:17:07PM