jrProfileTweaks bug

@dim
7 years ago
167 posts

If the active skin is Skin1, but the active profile skin is Skin2
and skins 1 and 2 are allowed in jrProfileTweaks,
the Skin1 will be displayed in the settings ("customize your profile"), but it will not be activated in the profile.
updated by @dim: 05/14/17 07:25:43PM

@dim
7 years ago
167 posts

Ie always will be activated the skin 2 only.
Just try to repeat my steps again.

@michael
7 years ago
7,746 posts

Thanks, will test and try to replicate the issue.

@michael
7 years ago
7,746 posts

Not able to reproduce.

skin1: Elastic 2
skin2: Nova

Visited profile, clicked profile settings, changed to CUSTOMZE tab. The currently selected skin was Elastic 2 (default). Changed it to "Nova" and visited the profile. Nova displays as expected.

Repeat steps and select "Elastic 2 (default)" and viewed the skin, profile now uses Elastic 2.

@dim
7 years ago
167 posts

I tried again.

Elastic 2 is the active skin
Nova is the active profile skin

Visited profile, clicked profile settings, changed to CUSTOMZE tab.
The currently selected skin was Elastic 2 (default). Click to "Save changes" and "Reset cache". Then I visited the profile and saw the skin ... Nova.

OK. Clicked profile settings. The currently selected skin was Elastic 2 (default). Changed it to "Nova" and visited the profile. Nova displays as expected.

Clicked profile settings. The currently selected skin was Nova. Changed it to "Elastic 2 (default)". Click to "Reset cache". Visited the profile. Elastic 2 does not displays as expected. Nova displays.

I tested it on 2 of my sites.
updated by @dim: 01/26/17 03:19:36AM

@brian
7 years ago
10,148 posts

Are you using BOTH Profile Tweaks and the Admin Skin module? If so, make sure if you have set Nova as the profile skin in Admin Skin that it is ALSO an allowed skin in the Profile Tweaks quota for the profile.

I will warn you as well that there are _some_ areas of the site that will not follow the admin skin setting - so just an FYI that if you are interested in maintaining a consistent UI on your site you should not be using Admin Skin.

Let me know if that helps.

--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
updated by @brian: 01/26/17 12:11:42PM

@dim
7 years ago
167 posts

brian:
Are you using BOTH Profile Tweaks and the Admin Skin module?

Yes of course. As you know, I can not use "the active profile skin" without the Admin Skin.

brian:
make sure if you have set Nova as the profile skin in Admin Skin that it is ALSO an allowed skin in the Profile Tweaks quota for the profile.

1. I tried to set Nova as the active admin skin and Elastic 2 as the active admin skin, but it does not help.
2. Nova and Elastic 2 is 2 allowed skins in the Profile Tweaks for all quotas

brian:
I will warn you as well that there are _some_ areas of the site.....

I know it. I'm talking about the main profile page.

@brian
7 years ago
10,148 posts

Sorry - you made no mention of Admin Skin so I wanted to be sure.

Profile Tweaks works independently of Admin Skin - it doesn't "know" that you're overriding the main site skin with a different skin for profiles, so it's not going to show Nova as the default in Profile Tweaks.

I'll see if I can spot any issues with this and let you know.

--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

@dim
7 years ago
167 posts

Nova and Elastic 2 is 2 allowed skins in the Profile Tweaks for all quotas
and here are the results:

1)
Elastic 2 is the active skin
Elastic 2 is the active admin skin
Nova is the active profile skin

Nova is displayed on a profile page. Elastic 2 is not displayed on a profile page despite the fact that it is marked by default enabled.

2)
Elastic 2 is the active skin
Nova is the active admin skin
Nova is the active profile skin

Nova is displayed on a profile page. Elastic 2 is not displayed on a profile page despite the fact that it is marked by default enabled.

3)
The admin skin is off
Elastic 2 is the active skin
Nova is the active profile skin

Nova is displayed on a profile page. Elastic 2 is displayed on a profile page. No problems. However, it does not help to solve my problem.
I want to set Elastic 2 as the active skin and Nova as the active profile skin + Elastic 2 as an additional profile skin for user selection.

@dim
7 years ago
167 posts

brian:
Sorry - you made no mention of Admin Skin so I wanted to be sure.

I tried to use the Profile Tweaks with the Admin Skin and without the Admin Skin.

@brian
7 years ago
10,148 posts

I have just tested this without Admin Skin active and I see no issues. Please disable admin skin and let me know if you see any issues.

--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

@dim
7 years ago
167 posts

Can you give me access to your ane test or demo site? I will be able to replicate the problem there.

@brian
7 years ago
10,148 posts

dim:
Can you give me access to your ane test or demo site? I will be able to replicate the problem there.

We don't give out the master login for our demo sites - sorry!

--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

@dim
7 years ago
167 posts

brian:
I have just tested this without Admin Skin active and I see no issues. Please disable admin skin and let me know if you see any issues.

See my test 3 above. If I disable Admin Skin in this case it will be impossible to set Elastic 2 as the active skin and Nova as the active profile skin + Elastic 2 as an additional profile skin for user selection.

@brian
7 years ago
10,148 posts

Yeah I think for now you should set Elastic 2 as the default profile skin and let the user choose Nova. There's a lot of "work arounds" inside Admin Skin that can result in weird issues just like this - to be honest if it weren't already being used by sites we would not make Admin Skin available - it's problematic as it requires us to hard code specific paths/views, and so anytime anything new is added, changed, or a site is customized, it is open to breaking.

I know that's probably not the answer you were looking for, and we will check it out and see if it is fixable, but for now having the defaults in admin skin and profile tweaks "line up" is your best bet.

--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

@dim
7 years ago
167 posts

OK. Brian, I understand you. But it would be great if you can reproduce this bag and fix it in the near future.

Maybe I was not able to correctly formulate the problem because of my poor English. I'm just surprised that you could not reproduce the problem. So I'll write about it again, one last time

Just to make sure that you understand the problem

Now "Elastic 2" is the active skin and the active profile skin on my site.
And "Nova" is an additional profile skin by the Profile Tweaks. Elastic 2 is the active admin skin.
It does not allow me to set "Nova" as a default profile skin.
So users must enable the "Nova" skin in their profiles.

If I set "Elastic 2" as the active skin and "Nova" as the active profile skin and "Elastic 2" or "Nova" as the active admin skin - in this case "Elastic 2" does not displays in a profile - "Nova" displays only, despite any "customize settings" in a profile.

Thanks!

@dim
7 years ago
167 posts

Maybe I know the reason for the error, but I could not find it in the php file (I know PHP a little bit).
I think there is an error in the index.php of the Profile Tweaks. The Profile Tweaks takes the default value for the active profile skin but should takes the default value for the active skin. Maybe

@brian
7 years ago
10,148 posts

I've just been checking this out, and am following this:

Quote:
If I set "Elastic 2" as the active skin and "Nova" as the active profile skin and "Elastic 2" or "Nova" as the active admin skin - in this case "Elastic 2" does not displays in a profile - "Nova" displays only, despite any "customize settings" in a profile.

And I don't see any issue (see my screenshot).

Note that I DID find one issue that is fixed in the next release, and that is if the skin a profile is set to is NO LONGER allowed in it's quota, but was set BEFORE the quota was changed, then it would still show - now it will show the site skin.

--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

@brian
7 years ago
10,148 posts

Here's a few more screenshots showing my config.

--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

@michael
7 years ago
7,746 posts

Can see this now. Will look into it. The Admin Skin is doing what its supposed to do in changing the skin to the non default one when it is active.

Profile Tweaks is changing the default skin for that profile to whatever is selected in the CUSTOMZE tab then the Admin Skin module is kicking in and changing it.

Understand the problem.

@brian
7 years ago
10,148 posts

Awesome - thanks Michael - glad you were able to reproduce it.

--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

@dim
7 years ago
167 posts

Great, thanks!!!
I do not understand why you could not reproduce the problem yesterday. As I understand it, you and I have done the same and repeated the same steps several times, is not it?

@michael
7 years ago
7,746 posts

couldnt reproduce it yesterday because I didnt know the Admin Skin module was involved.

@dim
7 years ago
167 posts

OK, @michael thanks!
And Brian?
I watched his screenshots and I had the same screenshots, believe me!

@michael
7 years ago
7,746 posts

This is fixed in the current version of jrProfileTweaks 1.3.12 which is in the marketplace now.

The issue is the (default) option wasn't showing the correct option that the profile would be reverted to. Should be good now.

@dim
7 years ago
167 posts

@michael,
Now there is a new problem. I can not save changes in the CUSTOMZE tab. Changes can not be saved.

@dim
7 years ago
167 posts

Please watch the video.

@michael
7 years ago
7,746 posts

I like videos, thanks. watching.

@michael
7 years ago
7,746 posts

I can see from the videos that the form is not changing, but is the profile? when you visit the profile, has the skin changed?

Will setup to test here.

@michael
7 years ago
7,746 posts

Can reproduce it here, looking for why now.

@dim
7 years ago
167 posts

michael:
when you visit the profile, has the skin changed?

The skin is not changed on my sites.

@michael
7 years ago
7,746 posts

We've got a solution for this situation in the next version of jrProfileTweaks v 1.3.13

When that comes out, you'll want to turn off the Admin Skin module and use the new "Default Skin" option in the Profile Tweaks module.

On the QUOTA CONFIG tab of the Profile Tweaks module you can now select which skin will be the default skin for profiles in that quota.

@dim
7 years ago
167 posts

Hi Michael,
I just upgraded the module and I see the same problem.
Please see the video for details.

michael:
when you visit the profile, has the skin changed?

Now the skin is not changed as well.

@michael
7 years ago
7,746 posts

did you disable the Admin Skin module and select the default module for that quota?

@michael
7 years ago
7,746 posts

looks like you did. try running the integrity check.

@dim
7 years ago
167 posts

michael:
looks like you did.

I did it.

michael:
looks like you did. try running the integrity check.

I did it too. But it does not help.

@dim
7 years ago
167 posts

Michael,
It turns out it works if the Admin Skin is activated.

Here is a working configuration:
Skin1 is set as active skin
Skin1 is set as active admin skin
Skin2 is set as active profile skin
"Allowed Profiles Skins" in "Quota Config" in the "jrProfileTweaks" are Skin1 and Skin2. And "Default Profile Skin" is Skin2.

This works correctly!
Only the admin skin for users is "Skin2" despite the fact that in settings: "Skin1 is set as active admin skin".
updated by @dim: 02/06/17 10:14:01PM

@michael
7 years ago
7,746 posts

I'll need to check this out.

The default_skin setting in ProfileTweaks is supposed to work as an alternative to Admin Skin for when you want different default skins for profiles in certain quotas. The Admin Skin sets one profile skin for everyone regardless of profile.

@michael
7 years ago
7,746 posts

It was not working as expected. I've changed the code around and have asked the team to test the new stuff. I believe its working as expected in this version:

jrProfileTweaks ver 1.3.13

Will get it released once its tested.

@dim
7 years ago
167 posts

dim:
Here is a working configuration:
...............
This works correctly!
Only the admin skin for users is "Skin2" despite the fact that in settings: "Skin1 is set as active admin skin".

This means that I found a configuration that allows me to solve my problem about which I wrote above. However, the module does not work correctly for other jamroom-users.

@michael
7 years ago
7,746 posts

Try it when the new version comes out. currently only 1.3.12 is in the marketplace.

@michael
7 years ago
7,746 posts

Released now. give that a go and see if you see any issues.

@dim
7 years ago
167 posts

I think now it`s working correctly.
Thank you, Michael!

@michael
7 years ago
7,746 posts

Good to hear

Thanks for helping us sort this issue out correctly.

solved jrProfileTweaks bug

Tags