Mention @member_name

Hello
A tiny challenge occurred in Jamroom 6.
I was able to mention members in posts using "@member-name."
Now this useful tool doesn't work.
I hope it will be easy to resolve.
It's a NingJa skin.

PS. Great work
updated by @joanna: 12/29/16 11:47:00AM

You should be able to mention users - I'm not seeing an issue with it here.

Where are you doing the mention at?

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

I tried to mention members in a blog post, in a group discussion and in comments on the site I work:

http://lewwwpcom.jamroomhosting.com/

Sometimes it works, sometimes not, please see attachments.

I don't believe it is supported in a blog post, but timeline entries and comments should be working.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

https://www.jamroom.net/the-jamroom-network/forum/new_posts/44102/jamroom-6-latest-activity-array-errors
The 'fix' mentioned here (not using custom templates) fixed this issue... but we're still trying to get back the functioning of things now lost... so will leave this open until we finish putzing around... hopefully this challenge will not re-appear.

There's no functionality lost in Jamroom 6, so let us know if you feel something is no longer working.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

Hi @brian

I see it works in a timeline now. But I still have a challenge with comments. Please, see an attachment.
Sometimes it works, sometimes not.

Thanks.

In comments it is either going to work every time, or fail every time - there's no decision in the process. Note that if you mention YOURSELF you will not be notified. You will also not receive notification if you modify a comment - only on the initial comment post.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

Also - one more thing to think about. If you mention someone on a PRIVATE item, and the user does not have access to it (such as comment on a ticket or private tracker), the user will not be notified.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

I mentioned these members in a public space.
I tried to mention other members, too, but I wonder why it works partially.

If it works, that's OK. If it doesn't work it's OK. But, when some names are hyperlinked when others not, it looks weird in a comment, don't you think?

If the name is NOT being hyperlinked, then the profile name does not exist in your system. Make sure you using the PROFILE name - i.e. @brian - and not the USER name.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

I tried to check active profiles.

As you might see in an attachment - in one comment @squirr is hyperlinked, in another isn't. @holly is also an active profile, but it's not hyperlinked.

Thanks for your time.

---edit
I've just discovered that @squirr and @holly are hyperlinked here, even though they are not active profiles here.
updated by @joanna: 09/29/16 12:56:09PM

So what is happening here is:

1) You are leaving a COMMENT on an item and mentioned someone
2) That comment causes an ACTION to be inserted into the Timeline
3) Since we do not show the full comment in the timeline, HTML is stripped from the comment

This is why the names are not hyperlinked. If you view the actual comment you will see that the names are hyperlinked IN the comment.

I've just looked at the default modules/jrComment/item_action.tpl file and it looks like we anticipated this and it appears to be setup correctly:
You can see the additional "at_tags" modifier call which formats those hyperlinks.

I just tested this scenario locally here and it is working - so if you have customized the jrComment/templates/item_action.tpl file then you'll want to fix that up.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
updated by @brian: 09/29/16 01:08:22PM

Yes, I know they are hyperlinked in the comment, and take me to an error - that's ok here. But, they are hyperlinked. It doesn't work on my site http://lewwwpcom.jamroomhosting.com/community/main_forum/6115/how-do-i-use-lewwwps-new-text-chat

I didn't modify modules/jrComment/item_action.tpl. I checked it and there is this code you mentioned.

Today I only modified: modules/jrComment/comment_form.tpl

What error?


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

Probably my English wasn't too good.
I know that @squirr here is not an active profile so when I click on it it takes me to the page "oops ... page not found." That's why I used the word 'error.' Sorry for confusion.

OK so that's not an error - that is working as it should be working. So the issue is why @joanna and @holly are not linked in the comment entry. I've tested here and cannot replicate the issue (it's working for me) so I will have to check this out on your site when I get a chance.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

Ok
Take your time, I know you are very busy.
I thought it might be connected with the new Jamroom 6.

If you need something more from me, just tell.

Thank you.

I have replicated this here and it's due to the editor placing paragraph tags around the names. I'm working on some other updates and will get this fixed up and pushed - should be by tomorrow.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net