Bug Report - Still A Problem With Forums Pagination (Slightly Diferent Problem) - The Jamroom Network

@soaringeagle
9 years ago
3,304 posts

now when theres 1 page only you don't see the pagination, but, when theres more then 1 theres a back button on page 1
on the last page theres a forward button to a non existant page

and whats worse my sitemap crawleres picking up odd urls by the thousands like
http://www.dreadlockssite.com/dreadlocks-forums/forum/introduce-yourself/80934/_self/_self/_self/_self/_self/p=12

notice the discussion title portion of the urls replaced by repeating _self
theres 12 pages in the url but its blank search by the title and you find a 4 page discussion

somethings still whacky

--
soaringeagle
head dreadhead at dreadlocks site
glider pilot student and member/volunteer coordinator with freedoms wings international soaring for people with disabilities
updated by @soaringeagle: 09/11/15 03:50:13PM

Strumelia
@strumelia
9 years ago
3,603 posts

I have not yet applied the new ProfileForum 1.6.1 update, and am holding off until i see what shakes out with this issue Soaring is reporting. Thanks

--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

@soaringeagle
9 years ago
3,304 posts

ps forum email notices no longer have any link to the topic or reply

--
soaringeagle
head dreadhead at dreadlocks site
glider pilot student and member/volunteer coordinator with freedoms wings international soaring for people with disabilities

Strumelia
@strumelia
9 years ago
3,603 posts

My forum notices do have live links- it took me right to this latest post of yours. So something different in our setups. Once difference is that I have not yet applied the 1.6.1 forum update, but it might be something else at work. Did you apply other latest module updates?

--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

@soaringeagle
9 years ago
3,304 posts

I always update when they come out
I'm also seeing other weirdness in my sitemap crawler ..like urls with p=180
when the discussions only 2 pages long

--
soaringeagle
head dreadhead at dreadlocks site
glider pilot student and member/volunteer coordinator with freedoms wings international soaring for people with disabilities

@soaringeagle
9 years ago
3,304 posts

I had to stop my sitemap crawl as it was finding hundreds of pages to discussions that were only 2 pages long
this is a serius problem

--
soaringeagle
head dreadhead at dreadlocks site
glider pilot student and member/volunteer coordinator with freedoms wings international soaring for people with disabilities

@brian
9 years ago
10,148 posts

I'm not seeing any issue here on Jamroom.net or on my dev system - can you show me how to replicate it here? Make sure if you have CUSTOMIZED the modules/jrForum/templates/email_topic_updated_message.tpl file in your template editor that you reset it and update it.

--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

@soaringeagle
9 years ago
3,304 posts

i had, but it was unchecked i reset it anyway but what about the fare more serrius issue of the pagination
i canyt run my sitemap crawler as it will never end because the pagination will have it crawling pages that dont exist
and search engine bots aswell will get lost
they can be looking at pages with p=56646754565664546
because the pagination never ends

--
soaringeagle
head dreadhead at dreadlocks site
glider pilot student and member/volunteer coordinator with freedoms wings international soaring for people with disabilities

@brian
9 years ago
10,148 posts

soaringeagle:
i had, but it was unchecked i reset it anyway but what about the fare more serrius issue of the pagination
i canyt run my sitemap crawler as it will never end because the pagination will have it crawling pages that dont exist
and search engine bots aswell will get lost
they can be looking at pages with p=56646754565664546
because the pagination never ends

I cannot see how this is an issue - you of course can put in any page you want, but you'll get a 404 if the page does not exist.

I don't see any issues with pagination here on jamroom.net or on my dev site.

--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

@soaringeagle
9 years ago
3,304 posts

ps found out the repeating _self was from setting "parse form action data' in the crawler so thats not an issue with the site however the never ending pagination is

--
soaringeagle
head dreadhead at dreadlocks site
glider pilot student and member/volunteer coordinator with freedoms wings international soaring for people with disabilities

@soaringeagle
9 years ago
3,304 posts

brian:

soaringeagle:
i had, but it was unchecked i reset it anyway but what about the fare more serrius issue of the pagination
i canyt run my sitemap crawler as it will never end because the pagination will have it crawling pages that dont exist
and search engine bots aswell will get lost
they can be looking at pages with p=56646754565664546
because the pagination never ends

I cannot see how this is an issue - you of course can put in any page you want, but you'll get a 404 if the page does not exist.

I don't see any issues with pagination here on jamroom.net or on my dev site.

its notthat you canput inany page number,and its not giving a 404
the problem is
on page 1 theres a back button with nowhere to go back to
on the last page theres a forward button with nowhere to go to
the forward takes you to a page with only the title
and...a forrward button
wich takes you to a page with just a title...and aforward button
infinately

--
soaringeagle
head dreadhead at dreadlocks site
glider pilot student and member/volunteer coordinator with freedoms wings international soaring for people with disabilities

@soaringeagle
9 years ago
3,304 posts

example
https://www.dreadlockssite.com/dreadlocks-forums/forum/dread-maintenance/4711/herbs-natural-remedies-useful-to-dreads-dreadcare
page 1 has a back button
page 3 has a forward button
actualy the dropdown gives you 3 page options but page 3 has only the title when you use the dropdown when you go back to page 2, thenm use the forward button you get page 3 with 2 replies
and a forward button
and u can continue clicking forward forever

--
soaringeagle
head dreadhead at dreadlocks site
glider pilot student and member/volunteer coordinator with freedoms wings international soaring for people with disabilities

@soaringeagle
9 years ago
3,304 posts

paginations not enabled on jr so you wont see it here
but look at my example page and you will see theres a back button on page 1 and on page 3 theres a forward button that takes you to p=4 with a forward to p=5
the search engine bots will continue to follow that uup to p=9999999999999999999999999999999
and beyond
because it infinately increments

--
soaringeagle
head dreadhead at dreadlocks site
glider pilot student and member/volunteer coordinator with freedoms wings international soaring for people with disabilities

@michael
9 years ago
7,715 posts

Got this fixed for the next core release. If you want to patch yours before the next core release comes out, its this:

/modules/jrCore/templates/list_pager.tpl

{* prev/next page profile footer links *}
{if $info.prev_page > 0 || $info.next_page > 0}
<div class="block">
    <table style="width:100%">
        <tr>
            <td style="width:25%">
            {if $info.prev_page > 0 && $info.prev_page != $info.this_page}
                {if isset($pager_load_id)}
                    <a onclick="jrCore_load_into('{$pager_load_id}','{$pager_load_url}/p={$info.prev_page}')">{jrCore_icon icon="previous"}</a>
                {else}
                    <a href="{$info.page_base_url}/p={$info.prev_page}">{jrCore_icon icon="previous"}</a>
                {/if}
            {/if}
            </td>
            <td style="width:50%;text-align:center">
                <form name="form" method="post" action="_self">
                {if isset($pager_load_id)}
                    <select name="pagenum" class="form_select list_pager" style="width:60px;" onchange="jrCore_load_into('{$pager_load_id}','{$pager_load_url}/p=' + $(this).val());">
                {else}
                    <select name="pagenum" class="form_select list_pager" style="width:60px;" onchange="window.location='{$info.page_base_url}/p=' + $(this).val();">
                {/if}
                {for $pages=1; $pages <= $info.total_pages; $pages++}
                    {if $info.this_page == $pages}
                        <option value="{$info.this_page}" selected="selected">{$pages}</option>
                    {else}
                        <option value="{$pages}">{$pages}</option>
                    {/if}
                {/for}
                    </select>&nbsp;/&nbsp;{$info.total_pages}
                </form>
            </td>
            <td style="width:25%;text-align:right">
            {if $info.next_page > 0 && $info.next_page <= $info.total_pages}
                {if isset($pager_load_id)}
                    <a onclick="jrCore_load_into('{$pager_load_id}','{$pager_load_url}/p={$info.next_page}')">{jrCore_icon icon="next"}</a>
                {else}
                    <a href="{$info.page_base_url}/p={$info.next_page}">{jrCore_icon icon="next"}</a>
                {/if}
            {/if}
            </td>
        </tr>
    </table>
</div>
{/if}

The bits that were added were:

{if $info.prev_page > 0 && $info.prev_page != $info.this_page}

and

{if $info.next_page > 0 && $info.next_page <= $info.total_pages}

Or just wait til the next core release comes out.

Thanks for finding this issue.

@soaringeagle
9 years ago
3,304 posts

thank you yes I need to patch it now

--
soaringeagle
head dreadhead at dreadlocks site
glider pilot student and member/volunteer coordinator with freedoms wings international soaring for people with disabilities

@soaringeagle
9 years ago
3,304 posts

perfect!!! thank you so much marking as solved
I assume since I did it through ftp, followed the symlink (to current version) and edited it there that it will just be replaced with the updated version when the symlink points to the next release
(as aposed to doing it in the in site template editor then having to reset it later)

--
soaringeagle
head dreadhead at dreadlocks site
glider pilot student and member/volunteer coordinator with freedoms wings international soaring for people with disabilities

@michael
9 years ago
7,715 posts

yep, that's a correct assumption. You're really getting to know how it works well.

Strumelia
@strumelia
9 years ago
3,603 posts

Love it!

Hey one question- did this problem pop up due to something in the new 1.6.1 update for ProfileForum module? I'm still holding off from doing that latest Forums update, thinking it's gonna cause this "pagination ad infinitum" issue...?

Is it ok now for me to go ahead and apply that ProfileForum 1.6.1 update ? Or should i wait for the next Core release and update both at that time?...to avoid the pagination glitch altogether? Thanks-

--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

@michael
9 years ago
7,715 posts

I don't think this is an issue thats going to effect the majority of people. Unless your running a separate script that spiders your own site you should be safe to update now.

The issue is: It is possible to click on the next page button even when there is no next page. So to any human user, its only going to be a novel experience for a very short time.

* click the next page button. url becomes site.com/something/p=2
* "oh, nothing here, ill click it again". url becomes site.com/something/p=3
* "oh, nothing here, ill click it again". url becomes site.com/something/p=4
* "oh, nothing here, ill click it again". url becomes site.com/something/p=5
* "oh, nothing here, ill click it again". url becomes site.com/something/p=6

a human user will get bored pretty quickly.

But if your running a separate script that follows every link, they don't get tired.
* SCRIPT: "follow each link until you've written them all to THIS file." -> GO

Scripts just do what they are told. That is the only instance where this could be a problem.

Strumelia
@strumelia
9 years ago
3,603 posts

Ok, I get that.

Now another question- I'm still on forum version 1.6.0
...I see now that update 1.6.1 is not in my update area anymore- it's been replaced by 1.6.2. Should I just go ahead and update directly to 1.6.2 now and forget about 1.6.1?

(thanks for bearing with me)

--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

@michael
9 years ago
7,715 posts

yes.

You will see in the changelog:
https://www.jamroom.net/the-jamroom-network/networkmarket/62/profile-forum/expanded_changelog=1

That 1.6.2 is the same as 1.6.1 + extra stuff.

Strumelia
@strumelia
9 years ago
3,603 posts

Ok done- thanks!

--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

solved bug report - still a problem with forums pagination (slightly diferent problem)

Tags