completed Events approval not working?

Strumelia
Strumelia
@strumelia
9 years ago
3,603 posts
I had previously made sure that Events were set to "Approve on create" so that regular quota members could create a new event but it would need admin approval before appearing. Then I signed in as a regular member and had no trouble creating a new event which immediately showed up on the Main page Timeline/Activity feed, and also shows up in the index page Coming Events List Panel/module.
Is the approval function not working right? I re-checked the approve on create setting and it's still set right. Thanks


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

updated by @strumelia: 05/22/15 11:46:38AM
Strumelia
Strumelia
@strumelia
9 years ago
3,603 posts
Update- ok so as admin, I just now received an email about the test member's 'pending' event, with options to Approve, Reject, or delete it. But....it's already there on the site even listed on the main page events lists. I see it right there as admin, and also when I'm logged in as the regular member.
Does it get created and get seen by everyone on the site BEFORE I decide whether or not to approve it? OR, am I as admin and the test member as the creator the only ones that can actually SEE it until i approve it?


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
paul
@paul
9 years ago
4,326 posts
I think that as Admin or Creator you will see it. After all, how would Admin know whether to approve it or not ;-)
Test by logging out and seeing if its still there.
Pa


--
Paul Asher - JR Developer and System Import Specialist
Strumelia
Strumelia
@strumelia
9 years ago
3,603 posts
I logged out, did a browser hard refresh... but I'm still seeing the event in the Events main page list module/panel, and also it's still there in the Actvity feed/timeline.


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
paul
@paul
9 years ago
4,326 posts
OK - Let us check that out.


--
Paul Asher - JR Developer and System Import Specialist
paul
@paul
9 years ago
4,326 posts
Not seeing an issue with this - pending events not showing when not logged in.


--
Paul Asher - JR Developer and System Import Specialist
Strumelia
Strumelia
@strumelia
9 years ago
3,603 posts
Well, it's there for me. Tested it with two different regular member profiles now, did refreshes, logged out, in, and out as various people- the two events are right there showing in all their glory. And neither have been approved yet. "Approve event on create" is checked for regular member quota.
events.jpg
events.jpg  •  784KB




--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

updated by @strumelia: 03/30/15 09:47:08PM
Strumelia
Strumelia
@strumelia
9 years ago
3,603 posts
Any other thoughts about this particular issue?


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
brian
@brian
9 years ago
10,148 posts
This is a bug in the Jamroom Core and is fixed for the next core release.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Strumelia
Strumelia
@strumelia
9 years ago
3,603 posts
Yay for you guys! You're the BEST !!! :D

I'll mark this 'solved'.


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
Strumelia
Strumelia
@strumelia
9 years ago
3,603 posts
Hey Brian, I just applied the newest Core update (april 9)

Was the Events pending function subject of this thread fixed, by the line described here?:

- Bug Fix: items created with attached media item may have pending flag reset

Just checking. If so ....thank you so much. :)


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
brian
@brian
9 years ago
10,148 posts
Yep - there were actually a couple bugs in the pending setup - should all be fixed now.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Strumelia
Strumelia
@strumelia
9 years ago
3,603 posts
Thank you - it is working now! :) Now my members won't be able to add an 'event' to the main site events calendar for every little thing -like if they buy a new dulcimer, or wash their hair... ;)

We should remember that when we are logged in as admin, we'll SEE the pending event already in the Events areas, as though it was already approved. But regular members WON"T see it listed in Events until we have approved it. I just tested it.

HOWEVER, even if it never gets approved, and even if it's deleted, the fact that a member "created XX event" will APPEAR in the main page activity timeline and everyone will see that along with the name of said member and name of pending event, ...but they won't see it added to the events page or events panel until or unless it gets approved (which may be never if the admin doesn't approve it.
It seems to me that a member would think their event went through ok- because they don't get a screen message that it's 'pending approval'...and they see it in the Timeline...but it doesn't show in the events areas. I can imagine I will be getting lots of messages from people asking why their event didn't appear after they added it. They don't get told that it's pending approval...it just doesn't show up yet. If my mods and I are away for a few hours, this might be frustrating for people and also cause me to have to send out a lot of responses ...all that could be avoided if they saw a simple onscreen note that their event will appear after admin approval. ? ;)


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
brian
@brian
9 years ago
10,148 posts
- your users will see a "this item is currently pending" when creating the item (or until it is approved)

- like the item, the timeline entry is only visible to admins and the user until the item is approved.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Strumelia
Strumelia
@strumelia
9 years ago
3,603 posts
brian:
- your users will see a "this item is currently pending" when creating the item (or until it is approved)

- like the item, the timeline entry is only visible to admins and the user until the item is approved.

I didn't see either of those behaviors when logged in as a regular user, but I'll try it again.


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
brian
@brian
9 years ago
10,148 posts
The User will see a notice like in my screenshot.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

updated by @brian: 04/11/15 08:29:12AM
Strumelia
Strumelia
@strumelia
9 years ago
3,603 posts
I hope to check this out later today, was up til midnight working on lamp drawings for a patent.
I thought I still had issues with this in Events (your screenshot shows blogs)...but I will test the events again later this afternoon with a regular member login, and will post back here. Thank you Brian!


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
brian
@brian
9 years ago
10,148 posts
It works the same regardless of the module - just tested on events and it is working here.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Strumelia
Strumelia
@strumelia
9 years ago
3,603 posts
Hi Brian,
I just did a bunch of tests...in events which are set to "approve on create" for members.
Here's the thing, it works, but in a somewhat incomplete way that is going to cause problems...I'll try to explain with screenshots-

I log in as a regular member. I go to CREATE a new event. Notice no message yet about awaiting approval. (screenshot1) I click 'create event, and...
pdf
1.pdf  •  108KB




--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

updated by @strumelia: 04/11/15 12:32:04PM
Strumelia
Strumelia
@strumelia
9 years ago
3,603 posts
ok then after clicking "Create event"...then new event APPEARS on the member's page under Events (screenshot 2) Still no message about awaiting approval....
pdf
2.pdf  •  320KB




--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

updated by @strumelia: 04/11/15 12:33:39PM
Strumelia
Strumelia
@strumelia
9 years ago
3,603 posts
the member now sees in their profile page timeline that the event was in fact "created". The new event also appears on that profile page's Timeline (screenshot 3)
This same Timeline notice also appears on the site's MAIN INDEX page Activity Timeline, for ALL to see (I logged in as another regular member and saw it on the main page timeline. Yet when other members click on it from the Timeline, they get a PAGE NOT FOUND at that event's URL. I foresee my getting a whole lot of puzzled messages on this issue every time an event is pending...from both the member creating the event and from those clicking on it from the Index page timeline.
pdf
3.pdf  •  235KB




--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

updated by @strumelia: 04/11/15 12:35:53PM
Strumelia
Strumelia
@strumelia
9 years ago
3,603 posts
Here are unapproved events created by regular members appearing in the ACTIVITY FEED tIMLINE ON MY SITE'S hOME iNDE PAGE...EVERYONE CAN SEE THEM AND CLICK ON THEM, BUT THEY SENFD YOU TO pAGE nOT fOUND. (oops sorry for the caps button!)
see here:
pdf
5.pdf  •  117KB




--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

updated by @strumelia: 04/11/15 12:38:19PM
Strumelia
Strumelia
@strumelia
9 years ago
3,603 posts
It's only if the member who created the unapproved event goes BACK and UPDATES/EDITS that event...that they will actually see the 'wait for approval' message (screenshot 4). They never see that message while CREATING the event.
NOtice Brian that in your screenshots, it's always in an "Update Event" window. If the member posts the event but does not go back for a few days to update it, they'll never have a clue. Meanwhile, other members are clicking to PageNotFound on the Activity feeds on the site Main page.

pdf
4.pdf  •  128KB




--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

updated by @strumelia: 04/11/15 12:44:30PM
brian
@brian
9 years ago
10,148 posts
This will be fixed up in the next core:

- timeline entries showing for pending items (this was a bug I introduced in my changes)
- I've added a new notice to let the user know the item they are creating will be pending

Hope this helps!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Strumelia
Strumelia
@strumelia
9 years ago
3,603 posts
YES- that's exactly what is needed- muchas gracias Brian! :)


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
Strumelia
Strumelia
@strumelia
9 years ago
3,603 posts
I just checked this again, and the 'hidden while pending' events functions are now working properly, as is the user's 'event pending' message. Thank you very much! :)


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015