ningja skin 1.0.16 changelog

Clay Gordon
Clay Gordon
@claygordon
9 years ago
733 posts
jrNingja
Ningja Skin changelog Version 1.0.16: 
- Change: Changed Tag Cloud height on the index page. 
- Change: Moved align-left image class to the image CSS file instead of the header CSS file. 
- Change: Changed the float order for the desktop menu so the Site Builder menu items get created in order. 
- Bug Fix: Profile sidebar could still show on forum pages even with Forum Profile URL set

Just so I know where to start looking for these changes ...

Tag cloud height in index.tpl?
Left-align image class in header.css?
Float order in header.css?
Bug fix - profile_sidebar.tpl?

So I don't need to do a module by module search.

TIA.

PS.

Although there have been discussions about how to make it easier for us to incorporate these changes into cloned skins, it occurs to me that one way to do this until a programmatic solution is arrived at is to add the location to the description.

jrNingja
Ningja Skin changelog Version 1.0.16: 
- Change: Changed Tag Cloud height on the index page. (index.tpl)
- Change: Moved align-left image class to the image CSS file instead of the header CSS file. (header.css | class name)
- Change: Changed the float order for the desktop menu so the Site Builder menu items get created in order. (header.css | class name)
- Bug Fix: Profile sidebar could still show on forum pages even with Forum Profile URL set. (profile_sidebar.tpl)

updated by @claygordon: 03/10/15 03:02:54PM
Strumelia
Strumelia
@strumelia
9 years ago
3,603 posts
Are some of these updates having to do with the thread Soaring just posted about the left column items now missing? I think maybe I need to know what I'm getting into on this particular ningja skin update.
However this sounds like it would be solving something for me, but not sure (dang!):
"Bug Fix: Profile sidebar could still show on forum pages even with Forum Profile URL set"


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
Clay Gordon
Clay Gordon
@claygordon
9 years ago
733 posts
Strumelia -

Maybe. I don't know.

One of the things I have started doing is to look at module templates BEFORE I do the update to see if I have modified any of them. That way I know which templates I have edited (if any) so I know where problems might arise.

I then copy what's been done in that changelog into a text editor as well as a list of the templates I've modified for that module.

Then I update the module. If things don't work the way I like, I can revert the module to the prior version.

Then I can go back and do a compare on the templates to see where the differences are and decide what I need to do. I can copy the affected code into the editor and think about the steps that need to be done to merge the changes as quickly as possible.

Then I can revert the revert and make the changes quickly. If I think it'll take more than a few seconds, I can put the site in maintenance mode for as long as it takes so that visitors don't have a bad experience.

HTH
Strumelia
Strumelia
@strumelia
9 years ago
3,603 posts
I hear you Clay. Unfortunately my custom skin has tons of template changes, and more are made every day. Isn't it just easier to make a custom skin clone right before applying the update, and then looking at the COMPARE if any problems pop up? Or does that not work well for reasons I don't understand yet?


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
Clay Gordon
Clay Gordon
@claygordon
9 years ago
733 posts
I suppose I could, but I had some pretty interesting problems getting my first clone skin to work that I am a little gun-shy about cloning (JR skins and in general).

When you make the clone you lose all indications of which templates have changed from the prior active skin.

I could apply the same technique I mentioned about the module templates to the skin templates. Make a note of which templates have been edited from the previous version and then look to see the diffs in just those templates, because those the only ones that matter.

It's getting late here. I need to think about that a bit when I am not as tired. Should work ... hmmm. Feeling the will to walk away from the computer weakening ...
Strumelia
Strumelia
@strumelia
9 years ago
3,603 posts
Step awaaaaaaay my friend...while you can.

(this from someone who just ate TWO boxes of cheap non-pareils.)


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
douglas
@douglas
9 years ago
2,790 posts
The templates modified are

index.tpl - changed the tag cloud height
header_menu_desktop.tpl - Rearranged to accommodate new float settings.
profile_header.tpl - Changed to fix the profile side from showing while on the forum page.

The align-left class was moved from the header.css to the image.css

And the float adjustments were done in the menu.css file.

You should be able to use the compare tool to find the actual changes in these files.

Hope this helps! :)


--

Douglas Hackney
Jamroom Team - Designer/Developer/Support
FAQ-Docs-Help Videos
Strumelia
Strumelia
@strumelia
9 years ago
3,603 posts
douglas:
You should be able to use the compare tool to find the actual changes in these files.

You mean through comparing my current active custom skin to the updated ningja skin?

But we have no compare tool for the .css files. :(
To 'compare' new ningja updates to my current custom ningja skin....for example the header.css...do i have to go through all settings for both, under "color and font', 'padding and margin', 'advanced', and 'untagged'...?


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

updated by @strumelia: 02/07/15 09:45:15AM
douglas
@douglas
9 years ago
2,790 posts
Yes, you should be able to compare your skin templates to jrNingja skin templates.


--

Douglas Hackney
Jamroom Team - Designer/Developer/Support
FAQ-Docs-Help Videos
Strumelia
Strumelia
@strumelia
9 years ago
3,603 posts

oops- repeating my question here:
I know how to do the template compares, but.... we have no compare tool for the .css files.
To 'compare' new ningja updates to my current custom ningja skin....for example the header.css...do i have to go through all settings for both, under "color and font', 'padding and margin', 'advanced', and 'untagged'...?



--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

updated by @strumelia: 02/07/15 09:46:51AM
Strumelia
Strumelia
@strumelia
9 years ago
3,603 posts
Ok, I just spent an hour combing carefully through my custom index template and the new Ningja index template....applying things I think i should to minimize differences, while conserving all the various custom stuff that both Paul and I have added over the past several months.
I thought I did everything right...but I must have screwed up something somewhere, because my Home page has now disappeared completely. =8-\

I can get to all my other site pages fine, and I just ran a complete cache and integrity check from there...but it didn't fix it.
I did clone my custom skin right before I made all the changes to it, but I'd hate to lose the whole hour of all those nice little tweaks to make my custom skin get some of the newer Ningja updates without losing my custom stuff. There are a 'lot' of differences in the index template, since I've changed/moved/added/deleted modules and such over time.

I don't know how to look for a 'bug' in the code of my index template to find out perhaps what is wrong now. Maybe there's a little snippet that needs fixing and I can still keep all the tweaks I just did and woon't have to start over?

Can someone look for any bug in my index template to see why my index page won't show up at all now?...please?
helllllllllp.... :(



--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

updated by @strumelia: 02/07/15 12:22:36PM
Strumelia
Strumelia
@strumelia
9 years ago
3,603 posts
Maybe Paul could take a look at what I may have goofed up?- since he did some of the modifications for me on my index template a few weeks ago.... ?


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
paul
@paul
9 years ago
4,326 posts
Strumelia:
Maybe Paul could take a look at what I may have goofed up?- since he did some of the modifications for me on my index template a few weeks ago.... ?

Done - You had a few {/if} statements missing or in the wrong place.


--
Paul Asher - JR Developer and System Import Specialist
Strumelia
Strumelia
@strumelia
9 years ago
3,603 posts
woo-HOOOOOO, I knew it had to be something little, 'cause I was being reeeeelly careful!

Ok, I have all my updates done now and looking ok.

THANK YOU!!!! :D



--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

updated by @strumelia: 02/07/15 04:08:45PM

Tags