solved Missing profile photo on private note

Clay Gordon
Clay Gordon
@claygordon
10 years ago
744 posts
jrImage_display: image item_id parameter required above the @ - which is empty.
jpg
 •  198KB


updated by @claygordon: 03/02/15 10:12:02PM
brian
@brian
10 years ago
10,148 posts
Ahh - that looks like a "System" note - I will get a fix in for that.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Clay Gordon
Clay Gordon
@claygordon
10 years ago
744 posts
What image is going to be used? Can I specify? I can think of about a gazillion images I would want to put there.

If the @ is @system then we want to make sure the member cannot click on @system.
brian
@brian
10 years ago
10,148 posts
thechocolatelife:
What image is going to be used? Can I specify? I can think of about a gazillion images I would want to put there.

If the @ is @system then we want to make sure the member cannot click on @system.

Of course - there is no system profile.

For image I'd probably go with the site logo.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

updated by @brian: 01/20/15 04:10:49PM
Clay Gordon
Clay Gordon
@claygordon
10 years ago
744 posts
In my case it's gonna look really ugly scaled and cropped to fit.

The creator's account record photo might be a better bet. Could "humanize" the communication - though it's coming from the system, it's actually coming from the root admin.
brian
@brian
10 years ago
10,148 posts
thechocolatelife:
In my case it's gonna look really ugly scaled and cropped to fit.

It would not be cropped - just have a width set, so let's see if that works as it makes the most "sense". We wouldn't want it to appear as if coming from a user (as it is not).


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Strumelia
Strumelia
@strumelia
10 years ago
3,603 posts
How about a square site favicon image?


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
Clay Gordon
Clay Gordon
@claygordon
10 years ago
744 posts
Brian -

Then you're scaling width and height will be what it will be. My logo is not square. I'd be happy to create a square - 300x300 - logo if that would help? Add it to the Skin's image list and call it system_note.jpg?
brian
@brian
10 years ago
10,148 posts
thechocolatelife:
Brian -

Then you're scaling width and height will be what it will be. My logo is not square. I'd be happy to create a square - 300x300 - logo if that would help? Add it to the Skin's image list and call it system_note.jpg?

That's correct - but at that width your logo should look fine even if it is not square? I'm hoping to avoid another configuration option here if we can help it.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Clay Gordon
Clay Gordon
@claygordon
10 years ago
744 posts
Try it and let's see. But it puts another design requirement on top of it. The basic approach to logos in all of the default JR skins is wide and short.

I don't want to make more work of this tonight than need be. If it's missing in my system - it's missing everywhere? So, let's think this out in a way that makes the most sense in the long run.
brian
@brian
10 years ago
10,148 posts
Thinking about this some more overnight, and I think the best bet is to have a config option to say "private notes sent by the system should come from user_id ##". That way it can then use a "real" user image, as well as allow a PN response.

If the value is NOT set (i.e. left at 0) then we'll default to showing the logo.

I think that is a good solution as it works "out of the box" as well as allows customization for those that want it.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

updated by @brian: 01/21/15 07:08:57AM
Clay Gordon
Clay Gordon
@claygordon
10 years ago
744 posts
Sounds good all the way around.

Tags