solved Text transform on profile menu

Clay Gordon
Clay Gordon
@claygordon
10 years ago
744 posts
There normally a "capitalize" text transformation on the menu items (in .profile_menu_entry class in profile.css). However, this means that YouTube is rendered as Youtube, which really bothers me.

As you can see in the screenshot I have set the transformation to "none" and everything except Timeline is all lowercase.

Now I want to go in and manually edit the labels that appear here.

I hope that someone will tell me that they are in a Language file somewhere. They are not in the Language file for the skin, and they are not in the language file for the User Profiles module, which (to me with my still limited understanding of things) is where I would expect them to be. They are not in the main (system core) language file, either.

From looking at the code in profile_menu.tpl ...

I see that the menu is built dynamically by querying for modules that are set to "active" ... but where is it pulling the menu name, which I am guessing is {$entry.label}?

Taking a look ... they don't look to be taken from module's URL as timeline is in all lower case
updated by @claygordon: 02/19/15 05:06:00AM
brian
@brian
10 years ago
10,148 posts
You can modify the menu items in the ACP -> (module) -> Language Tab - it's right at the top called "menu".

We can update this for a future release too.

Hope this helps!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

updated by @brian: 01/14/15 02:37:03PM
Clay Gordon
Clay Gordon
@claygordon
10 years ago
744 posts
Thanks. Staring right at me. Overthinking. Again.

Changes are preserved across module updates?
brian
@brian
10 years ago
10,148 posts
thechocolatelife:
Thanks. Staring right at me. Overthinking. Again.

Changes are preserved across module updates?

Yep - language customizations are always preserved.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Clay Gordon
Clay Gordon
@claygordon
10 years ago
744 posts
Brian -

Actually, sometimes maybe not?

I cloned the default ningja skin over the weekend and changes I made in in the skin's language settings were not recognized in the update. I've since re-entered the changes, but you may want to take a look at that.
brian
@brian
10 years ago
10,148 posts
thechocolatelife:
Brian -

Actually, sometimes maybe not?

I cloned the default ningja skin over the weekend and changes I made in in the skin's language settings were not recognized in the update. I've since re-entered the changes, but you may want to take a look at that.

If you Clone a skin, and then AFTER you clone the skin you update the skin you cloned FROM, the language strings in your clone will not be changed...

It's not clear to me though what you exactly mean, so hope that helps.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Clay Gordon
Clay Gordon
@claygordon
10 years ago
744 posts
Brian:

I changed the text associated with id numbers in the language section of the jrNingja2 skin.
I cloned the jrNingja2 skin to nsTCLSkin1
The changes were not in the cloned skin.
brian
@brian
10 years ago
10,148 posts
Yeah that would not be right - I'll check it out.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Clay Gordon
Clay Gordon
@claygordon
10 years ago
744 posts
Brian -

As I mentioned to Paul privately, I also had some issues with template files not being copied over, specifically related to the header.

I manually went back in and changed the logo image (in the images tab of the skin), header heights (in header.tpl), and the CSS (in header.css).
brian
@brian
10 years ago
10,148 posts
thechocolatelife:
Brian -

As I mentioned to Paul privately, I also had some issues with template files not being copied over, specifically related to the header.

I manually went back in and changed the logo image (in the images tab of the skin), header heights (in header.tpl), and the CSS (in header.css).

Were your changes made in the "template" editor online or did you make the changes in the templates? One thing that is important to know is that (currently) any template that is not "active" is not copied over, which is how it has been. That might be what you have seen, and we can update that so inactive customized templates are still copied over, but are left inactive.

Let me know if that helps.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

updated by @brian: 01/14/15 03:53:47PM
Clay Gordon
Clay Gordon
@claygordon
10 years ago
744 posts
To date, I have been making changes to templates solely in the ACP template editor. I sometimes copy the text into JEdit locally to look at it (for example long lines without scrolling and for search/replace, etc) but I always copy the changes back up rather than FTPing them. This means I can also save a local copy of template changes.

For CSS stuff it's been a mixed bag. Sometimes I will make the changes using the style editor in the ACP and sometimes I will make the changes locally and FTP them up.

There are a couple of reasons for this, the biggest of which is that sometimes the style editor interface won't offer me values I like.

One example of this is the class .blog-index-text in index.css. The ACP picker for line-height only offers 5 pixel increments and font-size doesn't offer odd heights above 14px. So I could not select, from the ACP style editor, 15 pixel text on 17 pixel line heights. This is weird because I can't ever see selecting a line height of 600px which is the limit of the picker. SO - something is going on there.

The picker for .blog-index-title also does not offer odd line heights above 14px.

The font-size range for most sites is going to be 7-24 px. and I really think that line-height can be specified numerically (either 1.1, 1.7) or % (110%, 170%) without any problem at all. Direct entry makes a lot more sense, maybe with a picker offering px, ##, or % as options.
brian
@brian
10 years ago
10,148 posts
thechocolatelife:
To date, I have been making changes to templates solely in the ACP template editor. I sometimes copy the text into JEdit locally to look at it (for example long lines without scrolling and for search/replace, etc) but I always copy the changes back up rather than FTPing them. This means I can also save a local copy of template changes.

For CSS stuff it's been a mixed bag. Sometimes I will make the changes using the style editor in the ACP and sometimes I will make the changes locally and FTP them up.

There are a couple of reasons for this, the biggest of which is that sometimes the style editor interface won't offer me values I like.

One example of this is the class .blog-index-text in index.css. The ACP picker for line-height only offers 5 pixel increments and font-size doesn't offer odd heights above 14px. So I could not select, from the ACP style editor, 15 pixel text on 17 pixel line heights. This is weird because I can't ever see selecting a line height of 600px which is the limit of the picker. SO - something is going on there.

This is actually a bug - line-height should be grouped with the other items that have single pixel values (border-width, etc.) so I will change that.

I've got some updates coming tomorrow as well for additional updates and fixes in the skin clone tool.

Hope this helps!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Clay Gordon
Clay Gordon
@claygordon
10 years ago
744 posts
Brian -

Hope so, too. The only things keeping me from going live are these little formatting details.

I could push it knowing that it's going to take 24-48 hours for DNS to propagate once I make the decision to go live.
brian
@brian
10 years ago
10,148 posts
thechocolatelife:
Brian -

Hope so, too. The only things keeping me from going live are these little formatting details.

I could push it knowing that it's going to take 24-48 hours for DNS to propagate once I make the decision to go live.

This is fixed in the next Core release - I will get a beta of 5.2.21 out tomorrow so you can update to that and check it out, as I've got this fixed.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Clay Gordon
Clay Gordon
@claygordon
10 years ago
744 posts
Brian -

I think that some of the issue is that I have been working with Paul and there is stuff that is hard-coded into the templates that could be done in the CSS. That's why some CSS changes don't "take".
Clay Gordon
Clay Gordon
@claygordon
10 years ago
744 posts
Two quick things on my home page now -

How to get rid of the little calendar icons on the Events block and where did the background color go in my Latest Forum Discussions block?
brian
@brian
10 years ago
10,148 posts
thechocolatelife:
Brian -

I think that some of the issue is that I have been working with Paul and there is stuff that is hard-coded into the templates that could be done in the CSS. That's why some CSS changes don't "take".

Yeah this is something we really need to do - over time a lot of these small style tweaks get built up in the templates and we need to get them moved back into the CSS classes. It requires an "audit" of the skin, which can take a long time, but we will work on that as we can.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
brian
@brian
10 years ago
10,148 posts
thechocolatelife:
Two quick things on my home page now -

How to get rid of the little calendar icons on the Events block and where did the background color go in my Latest Forum Discussions block?

I think that is in the modules/jrEvent/item_list.tpl file.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Clay Gordon
Clay Gordon
@claygordon
10 years ago
744 posts
brian:
thechocolatelife:
Brian -

I think that some of the issue is that I have been working with Paul and there is stuff that is hard-coded into the templates that could be done in the CSS. That's why some CSS changes don't "take".

Yeah this is something we really need to do - over time a lot of these small style tweaks get built up in the templates and we need to get them moved back into the CSS classes. It requires an "audit" of the skin, which can take a long time, but we will work on that as we can.

Thanks!

I am happy to offer up my site as a guinea pig for the process!
paul
@paul
10 years ago
4,335 posts
thechocolatelife:
Two quick things on my home page now -

How to get rid of the little calendar icons on the Events block and where did the background color go in my Latest Forum Discussions block?

The calendar icon is on line 101 of your index.tpl file, so maybe just remove that line.

Not sure where your background colour has gone. Need to check that the classes and styles declared in the forum template are the same as the other panels.


--
Paul Asher - JR Developer and System Import Specialist
Strumelia
Strumelia
@strumelia
10 years ago
3,603 posts
I was wanting to get rid of that little calendar icon too...
It's the line that ends in "calendar_icon.png", right? (for me it's line 99)


....worked! :)

Looks less "windows '95" now... hahaha

p.s. also on the line AFTER that (for 'titles' of the events), I changed the truncate to 30 instaed of 20, so that "Melodies &..." and "Those were the..." became "Melodies & Musings" and "Those Were the Days...". With the little calendar icon gone, there was room for a little more text there. :)



--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

updated by @strumelia: 01/15/15 06:08:57PM
Clay Gordon
Clay Gordon
@claygordon
10 years ago
744 posts
Good mentioning. I played with the truncate string length in a couple of places - for example I moved Forum posts from the right column to the left column and changed the trunc from 30 to 60 characters. Makes a huge difference.

It's the small things.
brian
@brian
10 years ago
10,148 posts
I think we just need to update the calendar icon to one that looks a little more "modern" - we can do that. Note that the small calendar icon links up to the calendar view, so just an FYI that if you remove it then you remove that quick link to the calendar.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Clay Gordon
Clay Gordon
@claygordon
10 years ago
744 posts
Brian -

I just commented out the icon ... so it's just a matter of finding something the same size that's more attractive and then replacing the existing icon in the Images tab of the ACP skin editor. Simple enough.

The one issue that's not resolved that way is that icon gets a little repetitive, visually.
Strumelia
Strumelia
@strumelia
10 years ago
3,603 posts
If one clicks on "All" in the Events module title, the little calendar icons are there again next to each event title.


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
douglas
@douglas
10 years ago
2,797 posts
Strumelia:
If one clicks on "All" in the Events module title, the little calendar icons are there again next to each event title.

You can modify your Events Module > Templates > item_list.tpl and remove them from there if you like.

:)


--

Douglas Hackney
Jamroom Team - Designer/Developer/Support
FAQ-Docs-Help Videos
Clay Gordon
Clay Gordon
@claygordon
10 years ago
744 posts
I don't mind them so much on the Events page because they are in-line with the event name. On the home page they are in a separate column.

A more interesting question - for me, is how to modify the "All" on the home page so that we see the calendar for the current month as the default view.
brian
@brian
10 years ago
10,148 posts
Just an update that the line-height sizing issue is fixed in jrCore 5.2.21. It also allows you to select any pixel size fro 8px -> 96px for font size.

Hope this helps!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Clay Gordon
Clay Gordon
@claygordon
10 years ago
744 posts
Brian -

I am looking forward to finding out if it does!

Tags