in progress After deleting a discussion, getting returned to the wrong page

Clay Gordon
Clay Gordon
@claygordon
10 years ago
744 posts
From my profile page I click on a discussion in the "Latest Discussions" panel.

On the discussion page I delete the discussion.

The return URL is .../username/group_discuss and the path in the header pane is:

Discussions
ChocLifeRoot » Groups » » Discussions

And there are no discussions on this page. You can sense confusion over the issue of group discussions over forums here because of the gap in the breadcrumb.

What I REALLY want to do is one of two things:

A) go back to my profile page

OR

B) Go to a Discussions page where all of MY discussions IRRESPECTIVE of what group or category they belong to OR to my Profile page where they are presented inline, i.e., in the fashion that Pages are presented.

updated by @claygordon: 02/14/15 08:56:23AM
paul
@paul
10 years ago
4,335 posts
Yep - I'm seeing that as well. Let me check it out.
Thanks


--
Paul Asher - JR Developer and System Import Specialist
paul
@paul
10 years ago
4,335 posts
This will be fixed in the next release.
Thanks


--
Paul Asher - JR Developer and System Import Specialist
paul
@paul
10 years ago
4,335 posts
jrGroupDiscuss V1.0.6 now in the Marketplace


--
Paul Asher - JR Developer and System Import Specialist
Clay Gordon
Clay Gordon
@claygordon
10 years ago
744 posts
Paul: This now works ... to a point. We still need to address the question of Discussions vs. Forums and what that means WRT to discussions that belong to Groups and Discussions that don't - and so are a part of the Main Discussion Forum.

On my profile page, the panel now says latest Forum But when I click on "All" it takes me to

http://www.thechocolatelife.info/thechocolatelife/chocliferoot/group

when it SHOULD take me to the equivalent of

http://www.thechocolatelife.info/thechocolatelife/chocliferoot/forum/my_posts -- with the sort on _updated, not _created

That's what I would expect to happen. I am on my profile (or any other profile) and want to see all of my discussions or the discussions of the member whose proflie I am looking at.

Note that there is no stat for " Discussions ". Adding one in would not solve the UI issue, but I think the behavior is analgous.
brian
@brian
10 years ago
10,148 posts
The changes you are looking for would be handled at the skin level - not at the Group Discussion module level.

We have a ticket open on this exact issue right now, and Douglas is working on it, so we should have that out fairly soon.

Hope this helps!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Clay Gordon
Clay Gordon
@claygordon
10 years ago
744 posts
@Brian -

Thanks for letting me know. I am happy to test so looking forward to taking a look at this soonest.

:: Clay
Strumelia
Strumelia
@strumelia
10 years ago
3,603 posts
Yep I am hoping for this to be resolved as well- it's very confusing when navigating our sites.
Go Douglas!


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
Clay Gordon
Clay Gordon
@claygordon
10 years ago
744 posts
Can I assume that an update to the skin will overwrite all of the changes I've made?

I need to do a DIFF on all the files I've changed, make note of the changes, and then re-incorporate the changes?
brian
@brian
10 years ago
10,148 posts
thechocolatelife:
Can I assume that an update to the skin will overwrite all of the changes I've made?

No.. your changes are never overwritten. When you upgrade a skin or module, the new version is installed into a separate directory, and the "active" link is updated to point to it. So at no time is anything you've customized ever overwritten.

If you make changes directly to templates (say skins/jrNingja/index.tpl) then when you update the NEW index.tpl will take over. You would have to copy your old index.tpl file (now in a directory like skins/jrNingja-release-1.0.11) back over into the "active" directory (just named "jrNingja").

However, that's not the way you want to be customizing your site :)

Instead do it this way:

- go to ACP -> Tools -> Developer Tools -> Tools -> Clone Skin and make a CLONE of the jrNingJa skin. This will include any customizations you have made to this point. Name it something like myCustomNingja, and make it your active skin.

- now, whenever a new Ningja skin update comes out you can safely update, since jrNingja is not your active skin.

- after the update, go into the "templates" tab for your custom skin and use the "compare" button to compare your custom templates to the same templates in the new jrNingJa update. If you see a template has changed and you want to incorporate those changes in to your custom skin, you can click on the button at the bottom to overwrite your custom template with that template from the jrNingja. If you have other customizations and don't want to overwrite them, you can see what the changes are and manually copy them in to your template.

Let me know if that helps.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Clay Gordon
Clay Gordon
@claygordon
10 years ago
744 posts
@Brian it does help.

I get the sense that a Skin update will happen soon. I will clone the skin I am working in before I update, and then do as you suggest to transfer the changes I have made to the new skin. I don't think it's going to be as simple as copying and overwriting. Sigh.

:: Clay
brian
@brian
10 years ago
10,148 posts
thechocolatelife:
Sigh.

Have done customizations outside of templates that you feel won't be easy to transfer? Ideally it shouldn't be hard at all (maybe take 10 minutes of your time...)


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Clay Gordon
Clay Gordon
@claygordon
10 years ago
744 posts
@Brian:

It's not the time, it's the cognitive burden. I don't do any form of coding on a regular basis so nothing is a habit.

It all goes back to one of my first bosses, who wanted me to critique what the code was doing by interacting with the UI and compare it against the functional specs, not critique the code itself. I learned enough to be able to communicate to the developers how I thought the implementation differed from the spec - or if we got the spec wrong, how it could be made to work better.

I think that focus shows in my questions in this forum.
brian
@brian
10 years ago
10,148 posts
thechocolatelife:
@Brian:

It's not the time, it's the cognitive burden. I don't do any form of coding on a regular basis so nothing is a habit.

I hear you. Hopefully keeping up to date using the "Compare" tool isn't too much work - we've tried to make it as easy as we can. Unfortunately when customizing things there's always going to be a little bit of overhead.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Clay Gordon
Clay Gordon
@claygordon
10 years ago
744 posts
@Brian -

I don't want to hijack this thread by going into a discussion about my challenges as a coder. The issue of where the user is taken after deleting a discussion is what' I want to return to.

When you know what the changes are in the skin please let me know and I will be happy to test them before they get put into a skin update.
paul
@paul
10 years ago
4,335 posts
This has been fixed in the latest version (1.0.6) of the jrGroupDiscuss module.Install it from your marketplace.
Maybe I should have marked this thread as solved. I'll do it now.


--
Paul Asher - JR Developer and System Import Specialist
Clay Gordon
Clay Gordon
@claygordon
10 years ago
744 posts
thechocolatelife:
Paul: 1.0.6 works ... to a point. We still need to address the question of Discussions vs. Forums and what that means WRT to discussions that belong to Groups and Discussions that don't - and so are a part of the Main Discussion Forum.

On my profile page, the panel now says latest Forum But when I click on "All" it takes me to

http://www.thechocolatelife.info/thechocolatelife/chocliferoot/group

when it SHOULD take me to the equivalent of

http://www.thechocolatelife.info/thechocolatelife/chocliferoot/forum/my_posts -- with the sort on _updated, not _created

paul
@paul
10 years ago
4,335 posts
The next version of the Ningja skin will address this.
Thanks


--
Paul Asher - JR Developer and System Import Specialist
paul
@paul
10 years ago
4,335 posts
Quote:
when it SHOULD take me to the equivalent of

http://www.thechocolatelife.info/thechocolatelife/chocliferoot/forum/my_posts -- with the sort on _updated, not _created

Have been thinking about this and my immediate thought is that now we have established the difference in terminology between forums and discussions, you are asking for a link in a 'discussion' panel to take you to a forum page which could well cause confusion. I think it needs to go to a listing of the profile's discussions. Also, you are asking things to be ordered by 'updated' where 'created' is the norm for all other Jamroom items by default. In this instance, in particular, a user could repeatedly update his post in order to keep his discussion at the top of the list. For these reasons, the default will be 'created'. Of course, you can change that in your template if you want :-)
Thanks
Pa


--
Paul Asher - JR Developer and System Import Specialist
Clay Gordon
Clay Gordon
@claygordon
10 years ago
744 posts
@Paul -

I think it's important to consider the context.

Members (other than admins) can only delete discussions they created, but they can be deleted in at least the following contexts:

1) The member's profile
2) From within a Group's discussions (which are always displayed within the context of a profile)
3) From within a Forum

To generalize, I suppose the answer is to display the parent context:

1) If I delete an entry from a Forum category discussion I would go to the listing of the Forum category:
e.g., http://...path.../forum/forum_name

2) If I delete an entry from a Group's discussion I go to the listing of that Group's discussions:
e.g., http://...path.../profile_name/group/#/group_name

As for the ordering, I don't have that particular sort of spam issue so I am not worried about people needlessly updating a discussion just to make sure it stays at the top of the list. But that's my community and I review every single request for membership.
updated by @claygordon: 01/04/15 12:08:44PM
brian
@brian
10 years ago
10,148 posts
I believe this is exactly how it will be setup once everything is rolled out.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

Tags