blog documentation FAQ followers forum marketplace services youtube

solved Edit Style form skin jumper select menu

The Jamroom Network » Forum » Jamroom Developers » Page » Edit Style form skin jumper select menu
SteveX
SteveX
@ultrajam
11 years ago
2,584 posts
https://mysite.com/core/skin_admin/style/skin=jrElastic

The skin jumper select menu on the above url isn't closed correctly - there is no ending /select tag. It doesn't seem to break things if it is used in a table cell, but badly breaks the page when it's moved outside of a table cell.

If I put an /select tag after {$subtitle} in page_banner.tpl everything works well.

You can verify that by putting {fdebug($subtitle)} in page_banner.tpl (cool that you can use fdebug in a template for reading things which are longer than {debug} will display in the popup!)


--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)
updated by @ultrajam: 05/04/14 06:16:20PM
brian
@brian
11 years ago
10,149 posts
I will check this out - thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
SteveX
SteveX
@ultrajam
11 years ago
2,584 posts
You can fix this by adding the closing select tag at line 5688 of /modules/jrCore/index.php

$subtitle .= '</select>';



--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)
SteveX
SteveX
@ultrajam
11 years ago
2,584 posts
Other functions which output similarly broken select menus:

function jrCore_show_skin_images

function jrCore_show_skin_templates

function jrCore_show_skin_info

function jrUser_show_module_lang_strings (there are two, the first has the /select, but not the one in the "else")


--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)
updated by @ultrajam: 04/01/14 05:03:36AM
brian
@brian
11 years ago
10,149 posts
Ouch - not sure how this got overlooked. Fixing them now.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
brian
@brian
11 years ago
10,149 posts
I've got all these fixed for the next release of the core.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
brian
@brian
11 years ago
10,149 posts
These are all fixed in jrCore 5.1.34 - let me know if you see any issues.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
SteveX
SteveX
@ultrajam
11 years ago
2,584 posts
Thanks Brian :)


--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)
SteveX
SteveX
@ultrajam
11 years ago
2,584 posts
Still one to go, visible when viewing core/skin_admin/language/skin=jrElastic
Line 989 of modules/jrUser/include.php needs an /select


--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)
brian
@brian
11 years ago
10,149 posts
Yep I see it - fixing it.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

Tags