solved Recovering a small skin customization I lost when I moved to jr6

Strumelia
Strumelia
@strumelia
8 years ago
3,605 posts
Before I moved from jr5 to jr6, I had a customization in my active skin that i suspect got lost when the 'array' issue got fixed up. This customization was I believe in my skin's Index.tpl, the the section concerning the home page activity feed. I think I see the code lines in an old skin backup, but I want to be careful about adding them back lest I BUST something. L O L

My Index page activity feed had two things customized so they would NOT show up in the activity timline: 1) when a member 'follows' another member (which still seems to be working just fine!) and 2) when a member leaves a Comment on another member's Profile page comment wall...like the terribly repetitive "Hi, welcome to the site!" type comments that get so tiresome to see all day long on the site's main page. This customization stopped working when I moved to 6, and I'd like to recover the bit of code that keeps those 'welcome comments' from appearing in the Index page timeline.
Here is my active skin's CURRENT (jr6) index.tpl section code for my activity section:
{* BEGIN Activity Section *}
            <div class="col8">

                <div class="title m10">
                    <h2>{jrCore_lang skin=$_conf.jrCore_active_skin id="20" default="Latest"} {jrCore_lang skin=$_conf.jrCore_active_skin id="27" default="Activity"}</h2>
                </div>

                {* BEGIN Activity Section *}
                <a id="activdiv" name="activdiv"></a>
                <div id="activitydiv" style="margin: 10px 10px 0 10px;padding-bottom: 10px;">
                    <div class="item"{if !jrCore_is_mobile_device()} style="max-height:916px;overflow-y:auto;overflow-x:hidden"{/if}>
                        {jrCore_list module="jrAction" search1="action_module != jrFollower" order_by="_item_id desc" pagebreak=50 page=$_post.p}
                        <br>
                        <div style="width:100%;text-align:center;padding:10px">
                            <a href="{$jamroom_url}/timeline">View More</a>
                        </div>
                    </div>
                </div>

            </div>
            {* END Activity Section *}

and here is my older (November) jr5 comparison of the same template and section, which I assume has the code line that will keep those profile page comments OFF the timeline on Index page:
{* BEGIN Activity Section *}
            <div class="col8">
                <div class="title m10">
                    <h2>{jrCore_lang skin=$_conf.jrCore_active_skin id="20" default="Latest"} {jrCore_lang skin=$_conf.jrCore_active_skin id="27" default="Activity"}</h2>
                </div>
                {***jrCore_list module="jrAction" search1="action_module != jrFollower" search2="action_data NOT_LIKE %\"comment_module\":\"jrProfile\"%" order_by="_item_id numerical_desc" template="index_activity.tpl" pagebreak=50 page=$_post.p***}
                {jrCore_list module="jrAction" search1="action_module != jrFollower" order_by="_item_id numerical_desc" template="index_activity.tpl" pagebreak=60 page=$_post.p}
            </div>
            {* END Activity Section *}

Can anyone tell me if I've focused on the right area and have the right idea here- and if so, what line of code to take from the old version and WHERE exactly it should be placed in the new version?
Thanks for any help! I have to be a bit careful here, because this is my main live site, and I'm not that good at this stuff. ;)


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

updated by @strumelia: 05/05/17 07:41:09AM
douglas
@douglas
8 years ago
2,806 posts
Try replacing this:

{* BEGIN Activity Section *}
<div class="col8">

    <div class="title m10">
        <h2>{jrCore_lang skin=$_conf.jrCore_active_skin id="20" default="Latest"} {jrCore_lang skin=$_conf.jrCore_active_skin id="27" default="Activity"}</h2>
    </div>

    {* BEGIN Activity Section *}
    <a id="activdiv" name="activdiv"></a>
    <div id="activitydiv" style="margin: 10px 10px 0 10px;padding-bottom: 10px;">
        <div class="item"{if !jrCore_is_mobile_device()} style="max-height:916px;overflow-y:auto;overflow-x:hidden"{/if}>
            {jrCore_list module="jrAction" search1="action_module != jrFollower" order_by="_item_id desc" pagebreak=50 page=$_post.p}
            <br>
            <div style="width:100%;text-align:center;padding:10px">
                <a href="{$jamroom_url}/timeline">View More</a>
            </div>
        </div>
    </div>

</div>
{* END Activity Section *}

with this:

{* BEGIN Activity Section *}
<div class="col8">

    <div class="title m10">
        <h2>{jrCore_lang skin=$_conf.jrCore_active_skin id="20" default="Latest"} {jrCore_lang skin=$_conf.jrCore_active_skin id="27" default="Activity"}</h2>
    </div>

    {* BEGIN Activity Section *}
    <a id="activdiv" name="activdiv"></a>
    <div id="activitydiv" style="margin: 10px 10px 0 10px;padding-bottom: 10px;">
        <div class="item"{if !jrCore_is_mobile_device()} style="max-height:916px;overflow-y:auto;overflow-x:hidden"{/if}>
            {jrCore_list module="jrAction" search1="action_module != jrFollower" search2="action_data NOT_LIKE %\"comment_module\":\"jrProfile\"%" order_by="_item_id numerical_desc" template="index_activity.tpl" pagebreak=50 page=$_post.p}            <br>
            <div style="width:100%;text-align:center;padding:10px">
                <a href="{$jamroom_url}/timeline">View More</a>
            </div>
        </div>
    </div>

</div>
{* END Activity Section *}

and see if that gives you the results your after.

Hope this helps!


--

Douglas Hackney
Jamroom Team - Designer/Developer/Support
FAQ-Docs-Help Videos
Strumelia
Strumelia
@strumelia
8 years ago
3,605 posts
Douglas- one question for safety before I try applying this suggestion-

I see the "search2" part addition you suggest I add (as I expected)
BUT- will I create any "jr5-to-jr6 problems" if I make your suggested change in the "order by" part?

current version is:
order_by="_item_id desc" pagebreak=50 page=$_post.p}

and the older version is:
order_by="_item_id numerical_desc" template="index_activity.tpl" pagebreak=50 page=$_post.p}

Just want to be sure first about that 'order by' part of the code changing- that it won't screw something up. ?


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

updated by @strumelia: 01/21/17 11:49:32AM
douglas
@douglas
8 years ago
2,806 posts
You can remove the numerical_ part, don't think it is needed.

Hope this helps!


--

Douglas Hackney
Jamroom Team - Designer/Developer/Support
FAQ-Docs-Help Videos
Strumelia
Strumelia
@strumelia
8 years ago
3,605 posts
Unfortunately, that doesn't seem to work even though it seems logical. Just tested it by making a new comment on a member's Profile page, which immediately showed up on the Index page Timeline. Did integ check of course, and browser refresh etc.
This is the new code as I changed it to (but it's not working):
{* BEGIN Activity Section *}
                <a id="activdiv" name="activdiv"></a>
                <div id="activitydiv" style="margin: 10px 10px 0 10px;padding-bottom: 10px;">
                    <div class="item"{if !jrCore_is_mobile_device()} style="max-height:916px;overflow-y:auto;overflow-x:hidden"{/if}>
                        {jrCore_list module="jrAction" search1="action_module != jrFollower" search2="action_data NOT_LIKE %\"comment_module\":\"jrProfile\"%" order_by="_item_id desc" pagebreak=50 page=$_post.p}
                        <br>
                        <div style="width:100%;text-align:center;padding:10px">
                            <a href="{$jamroom_url}/timeline">View More</a>
                        </div>
                    </div>
                </div>

            </div>
            {* END Activity Section *}



--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

updated by @strumelia: 01/21/17 01:11:51PM
michael
@michael
8 years ago
7,805 posts
do you have the code that was in index_activity.tpl?

suspect it was just jumping the entries that were welcome messages.
Strumelia
Strumelia
@strumelia
8 years ago
3,605 posts
michael:
do you have the code that was in index_activity.tpl?
suspect it was just jumping the entries that were welcome messages.
Michael, Yes I have a pre-jr6 copy of that skin tpl code.
Here it is but then I have to go out for a few hours- will be back later to check any response here.

Sorry the code's a bit long but I didn't wnat to omit anything possibly important:

 {* BEGIN Activity Section *}
<a id="activdiv" name="activdiv"></a>
<div id="activitydiv" style="margin: 10px 10px 0 10px;padding-bottom: 10px;">

<div class="item"{if !jrCore_is_mobile_device()} style="max-height:916px;overflow: auto;"{/if}>

    {if isset($_items)}

    {if (jrCore_module_is_active('jrComment') && $_items[0].quota_jrComment_allowed == 'on') || (jrCore_module_is_active('jrDisqus') && $_items[0].quota_jrDisqus_allowed == 'on')}
        {assign var="img" value="comments.png"}
        {jrCore_lang module="jrAction" id="22" default="Comments" assign="alt"}
    {else}
        {assign var="img" value="link.png"}
        {jrCore_lang module="jrAction" id="23" default="Link To This" assign="alt"}
    {/if}

    {jrCore_module_url module="jrAction" assign="murl"}
    {foreach from=$_items item="item"}
    
    {if !(isset($item['action_item']['comment_module']) && $item['action_item']['comment_module'] == 'jrProfile')}

    {* Shared Action *}
    {if isset($item.action_original_profile_url)}

    <div id="a{$item._item_id}" class="action_item_holder_shared">
        <div class="container">
            <div class="row">

                <div class="col2">
                    <div class="action_item_media" title="{$item.action_original_profile_name|jrCore_entity_string}" onclick="jrCore_window_location('{$jamroom_url}/{$item.action_original_profile_url}/{$murl}/{$item.action_original_item_id}')">
                        {jrCore_module_function function="jrImage_display" module="jrUser" type="user_image" item_id=$item.action_original_user_id size="icon" crop="auto" alt=$item.user_name class="action_item_user_img img_shadow img_scale"}
                    </div>
                </div>

                <div class="col9">
                    <div class="action_item_desc">

                        <a href="{$jamroom_url}/{$item.action_original_profile_url}" class="action_item_title" title="{$item.action_original_profile_name|jrCore_entity_string}">@{$item.action_original_profile_url}</a> <span class="action_item_actions">• {$item._created|jrCore_date_format:"relative"} • {jrCore_lang module="jrAction" id="21" default="Shared By"} <a href="{$jamroom_url}/{$item.profile_url}" title="{$item.profile_name}">@{$item.profile_url}</a></span><br>

                        <div class="action_item_link" title="{$item.action_original_profile_name|jrCore_entity_string}" onclick="jrCore_window_location('{$jamroom_url}/{$item.action_original_profile_url}');">
                            {if isset($item.action_data) && strlen($item.action_data) > 0}
                                {$item.action_data}
                            {else}
                                <div class="p5">{$item.action_text|jrCore_format_string:$item.profile_quota_id|jrAction_convert_hash_tags}</div>
                            {/if}
                        </div>

                    </div>
                </div>

                <div class="col1 last">
                    <div id="d{$item._item_id}" class="action_item_delete">
                        <script>$(function () { $('#a{$item._item_id}').hover(function() { $('#d{$item._item_id}').toggle(); }); });</script>
                        {jrCore_item_delete_button module="jrAction" profile_id=$item._profile_id item_id=$item._item_id}
                        {if jrUser_is_admin() && !jrProfile_is_profile_view()}
                        <a onclick="xxDeleteEntry('{$item._item_id}');">{jrCore_icon icon="trash" size=30}</a>
                        {/if}                        
                    </div>
                </div>

            </div>
        </div>
    </div>

    {* Activity Updates *}
    {elseif isset($item.action_text)}

    <div id="a{$item._item_id}" class="action_item_holder">
        <div class="container">
            <div class="row">

                <div class="col2">
                    <div class="action_item_media" onclick="jrCore_window_location('{$jamroom_url}/{$item.profile_url}/{$murl}/{$item._item_id}')">
                        {jrCore_module_function function="jrImage_display" module="jrUser" type="user_image" item_id=$item._user_id size="icon" crop="auto" alt=$item.user_name class="action_item_user_img img_shadow img_scale"}
                    </div>
                </div>
                <div class="col9">

                    <div class="action_item_desc">

                        <a href="{$jamroom_url}/{$item.profile_url}" class="action_item_title" title="{$item.profile_name|jrCore_entity_string}">@{$item.profile_url}</a> <span class="action_item_actions">• {$item._created|jrCore_date_format:"relative"}{if jrUser_is_logged_in() && $_user._user_id != $item._user_id && $item.action_shared_by_user != '1'} • <a href="{$jamroom_url}/{$murl}/share/{$item._item_id}" onclick="if(!confirm('{jrCore_lang module="jrAction" id="9" default="Share this update with your followers?"}')) { return false; }">{jrCore_lang module="jrAction" id="10" default="Share This"}</a>{/if} {if $_post.module_url == $_user.profile_url && $item.action_shared_by_user == '1'} • <a href="{$jamroom_url}/{$item.profile_url}/{$murl}/{$item._item_id}">{jrCore_lang module="jrAction" id="26" default="shared by you"}</a> {elseif $item.action_shared_by_count > 0} • {jrCore_lang module="jrAction" id="24" default="shared by"} <a href="{$jamroom_url}/{$item.profile_url}/{$murl}/{$item._item_id}">{$item.action_shared_by_count} {jrCore_lang module="jrAction" id="25" default="follower(s)"}</a>{/if}{if $img == "comments.png"} • <a href="{$jamroom_url}/{$item.profile_url}/{$murl}/{$item._item_id}">{jrCore_lang module="jrAction" id="22" default="Comments"}: {$item.action_comment_count|default:0}</a>{/if}</span><br>

                        <div class="action_item_link">
                            <div class="p5">{$item.action_text|jrCore_format_string:$item.profile_quota_id|jrAction_convert_hash_tags}</div>
                        </div>

                    </div>
                </div>
                <div class="col1 last">
                    <div id="d{$item._item_id}" class="action_item_delete">
                        <script>$(function () { $('#a{$item._item_id}').hover(function() { $('#d{$item._item_id}').toggle(); }); });</script>
                        {jrCore_item_delete_button module="jrAction" profile_id=$item._profile_id item_id=$item._item_id}
                        {if jrUser_is_admin() && !jrProfile_is_profile_view()}
                        <a onclick="xxDeleteEntry('{$item._item_id}');">{jrCore_icon icon="trash" size=30}</a>
                        {/if}                        
                    </div>
                </div>

            </div>
        </div>
    </div>

    {* Registered Module Action templates *}
    {elseif isset($item.action_data)}

    {jrCore_module_url module=$item.action_module assign="lurl"}

    <div id="a{$item._item_id}" class="action_item_holder">
        <div class="container">
            <div class="row">

                <div class="col2">
                    {if isset($item.album_title_url)}
                    <div class="action_item_media" onclick="jrCore_window_location('{$jamroom_url}/{$item.profile_url}/{$lurl}/albums/{$item.album_title_url}')">
                        {elseif isset($item.action_title_url)}
                        <div class="action_item_media" onclick="jrCore_window_location('{$jamroom_url}/{$item.profile_url}/{$lurl}/{$item.action_item_id}/{$item.action_title_url}')">
                            {else}
                            <div class="action_item_media">
                                {/if}
                                {jrCore_module_function function="jrImage_display" module="jrUser" type="user_image" item_id=$item._user_id size="icon" crop="auto" alt=$item.user_name class="action_item_user_img img_shadow img_scale"}
                            </div>
                        </div>
                        <div class="col9">

                            <div class="action_item_desc">

                                <a href="{$jamroom_url}/{$item.profile_url}" class="action_item_title" title="{$item.profile_name|jrCore_entity_string}">@{$item.profile_url}</a> <span class="action_item_actions">• {$item._created|jrCore_date_format:"relative"}{if jrUser_is_logged_in() && $_user._user_id != $item._user_id && $item.action_shared_by_user != '1'} • <a href="{$jamroom_url}/{$murl}/share/{$item._item_id}" onclick="if(!confirm('{jrCore_lang module="jrAction" id="9" default="Share this update with your followers?"}')) { return false; }">{jrCore_lang module="jrAction" id="10" default="Share This"}</a>{/if} {if $_post.module_url == $_user.profile_url && $item.action_shared_by_user == '1'} • <a href="{$jamroom_url}/{$item.profile_url}/{$murl}/{$item._item_id}">{jrCore_lang module="jrAction" id="26" default="shared by you"}</a> {elseif $item.action_shared_by_count > 0} • {jrCore_lang module="jrAction" id="24" default="shared by"} <a href="{$jamroom_url}/{$item.profile_url}/{$murl}/{$item._item_id}">{$item.action_shared_by_count} {jrCore_lang module="jrAction" id="25" default="follower(s)"}</a>{/if}</span><br>

                                {if isset($item.album_title_url)}
                                <div class="action_item_link" onclick="jrCore_window_location('{$jamroom_url}/{$item.profile_url}/{$lurl}/albums/{$item.album_title_url}')">
                                    {elseif isset($item.action_title_url)}
                                    <div class="action_item_link" onclick="jrCore_window_location('{$jamroom_url}/{$item.profile_url}/{$lurl}/{$item.action_item_id}/{$item.action_title_url}')">
                                        {else}
                                        <div class="action_item_link">
                                            {/if}
                                            {$item.action_data}
                                        </div>

                                    </div>
                                </div>
                                <div class="col1 last">
                                    <div id="d{$item._item_id}" class="action_item_delete">
                                        <script>$(function () { $('#a{$item._item_id}').hover(function() { $('#d{$item._item_id}').toggle(); }); });</script>
                                        {jrCore_item_delete_button module="jrAction" profile_id=$item._profile_id item_id=$item._item_id}
                                        {if jrUser_is_admin() && !jrProfile_is_profile_view()}
                                            <a onclick="xxDeleteEntry('{$item._item_id}');">{jrCore_icon icon="trash" size=30}</a>
                                        {/if}
                                    </div>
                                </div>

                            </div>
                        </div>
                    </div>

    {/if}
    
    {/if}
    
    {/foreach}
                    {if $info.total_pages > 1}
                        <div class="block">
                            <table style="width:100%;">
                                <tr>

                                    <td style="width:25%;">
                                        {if isset($info.prev_page) && $info.prev_page > 0}
                                            <input type="button" value="{jrCore_lang module="jrCore" id=26 default="<"}" class="form_button" onclick="jrLoad('#activitydiv','{$jamroom_url}/index_activity_list/p={$info.prev_page}/pb={$info.pagebreak}');$('html, body').animate({ scrollTop: $('#activdiv').offset().top -100 }, 'slow');return false;">
                                        {/if}
                                    </td>

                                    <td style="width:50%;text-align:center;">
                                        {if $info.total_pages <= 5}
                                            {$info.page}  / {$info.total_pages}
                                        {else}
                                            <form name="form" method="post" action="_self">
                                                <select name="pagenum" class="form_select" style="width:60px;" onchange="var sel=this.form.pagenum.options[this.form.pagenum.selectedIndex].value;jrLoad('#activitydiv','{$jamroom_url}/index_activity_list/p=' +sel+'/pb={$info.pagebreak}');$('html, body').animate({ scrollTop: $('#activdiv').offset().top -100 }, 'slow');">
                                                    {for $pages=1 to $info.total_pages}
                                                        {if $info.page == $pages}
                                                            <option value="{$info.this_page}" selected="selected"> {$info.this_page}</option>
                                                        {else}
                                                            <option value="{$pages}"> {$pages}</option>
                                                        {/if}
                                                    {/for}
                                                </select> / {$info.total_pages}
                                            </form>
                                        {/if}
                                    </td>

                                    <td style="width:25%;text-align:right;">
                                        {if isset($info.next_page) && $info.next_page > 1}
                                            <input type="button" value="{jrCore_lang module="jrCore" id=27 default=">"}" class="form_button" onclick="jrLoad('#activitydiv','{$jamroom_url}/index_activity_list/p={$info.next_page}/pb={$info.pagebreak}');$('html, body').animate({ scrollTop: $('#activdiv').offset().top -100 }, 'slow');return false;">
                                        {/if}
                                    </td>

                                </tr>
                            </table>
                        </div>
                    {/if}
    {/if}
</div>
</div>
{* END Activity Section *}



--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

updated by @strumelia: 01/21/17 03:50:01PM
michael
@michael
8 years ago
7,805 posts
yeah, thats it.

You're checking if the timeline entry is a comment on the profile and if it is skip it.
    {if !(isset($item['action_item']['comment_module']) && $item['action_item']['comment_module'] == 'jrProfile')}
...

So to get it back how it was, and only skip showing those messages on the front timeline, re-make the index_activity.tpl by copying the /modules/jrAction/templates/item_list.tpl to /skins/YOUR-SKIN/index_action.tpl

Then add that template into the jrCore_list with a template="index_action.tpl"

At this point you have EXACTLY the same as the default. Once thats working, then we start changing it.

The reason we do it like this instead of a direct override via the TEMPLATES tab in the ACP is that we still want to show those profile timeline comments on the profiles of the users who wrote them. (if you dont want them there too, then this could be done via an ACP edit.)

Let me know when thats done or if its too difficult and we'll rethink.
michael
@michael
8 years ago
7,805 posts
This is the test code we use:
<p><a href="https://www.youtube.com/watch?v=FdBF6h7oH5I">https://www.youtube.com/watch?v=FdBF6h7oH5I</a></p>
<p>thats  a link to the song.</p>
<p>this should be the card https://www.youtube.com/watch?v=FdBF6h7oH5I</p>

See expected output in the screenshot.

The first link is just a link, the second is converted.
Strumelia
Strumelia
@strumelia
8 years ago
3,605 posts
(I understand that your very last post was meant for my other thread by the way)
But as to this thread's issue again:

michael:
You're checking if the timeline entry is a comment on the profile and if it is skip it.
    {if !(isset($item['action_item']['comment_module']) && $item['action_item']['comment_module'] == 'jrProfile')}
...

Michael I don't understand why I can't fix this simply by adding the (above) old code line back again into my current skin's index_activity.tpl ...since apparently that code got left behind during my jr5-t-6 update? (what with the timeline/array stuff associated with that update). Between adding it back to my skin index_activity, and the reference to it I've added back to my skin's index.tpl that I did with Douglas in the beginning of this thread... why wouldn't that work?

Now I'm not even sure whether I should revert my skin's index.tpl back to what it was before I started this thread?- or leave in the change that Douglas suggested that I now have in place..? I'm getting confused now.

Quote: So to get it back how it was, and only skip showing those messages on the front timeline, re-make the index_activity.tpl by copying the /modules/jrAction/templates/item_list.tpl to /skins/YOUR-SKIN/index_action.tpl

Then add that template into the jrCore_list with a template="index_action.tpl"

At this point you have EXACTLY the same as the default. Once thats working, then we start changing it.

The reason we do it like this instead of a direct override via the TEMPLATES tab in the ACP is that we still want to show those profile timeline comments on the profiles of the users who wrote them. (if you dont want them there too, then this could be done via an ACP edit.)

Let me know when thats done or if its too difficult and we'll rethink.

Michael I've read over your instructions above several times and I think it's beyond what I can (safely) attempt on my live site, without having careful step by step help.
(incidentally, I should confirm that YES I do want to "still want to show those profile timeline comments on the profiles of the users who wrote them" as you mention above.)

To help me understand what you suggest i do-

First question: Are your instructions meaning that I'm I supposed to MAKE a template? ("Then add that template into the jrCore_list with a template="index_action.tpl"") If so, I gotta first figure out how to actually 'make' templates. Should I just Google that? (I think I can use just MS Notepad text editor?)

Second: am I supposed to leave IN the skin index.tpl change that Dougles first suggested at top of this thread? Or do i revert that change out again now, before attempting to proceed with anything else?

Thanks!


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

updated by @strumelia: 01/24/17 09:07:40AM
michael
@michael
8 years ago
7,805 posts
Its late here now, I'll get you sorted out tomorrow. :)
michael
@michael
8 years ago
7,805 posts
Strumelia:....
Michael I don't understand why I can't fix this simply by adding the (above) old code line back again into my current skin's index_activity.tpl ...since apparently that code got left behind during my jr5-t-6 update? (what with the timeline/array stuff associated with that update). Between adding it back to my skin index_activity, and the reference to it I've added back to my skin's index.tpl that I did with Douglas in the beginning of this thread... why wouldn't that work?....
It probably will, it will be the first thing I try.

But if there is an error, I expect it to come from the variable names being changed from the old activity system.

From jr5 to jr6 there was a lot of work done around the timeline area.

So the concept is the same, we want to not show the profile comments, but whether the variables are the same or not, im not certain.

so the steps I would take are:
* add that exact code in, see what happens.

If it works, it works. fine. if it doesnt work, put a {debug} in at that location and find out what the variables I want are, then adjust that line to use the correct variables.

That I expect would work.
Strumelia
Strumelia
@strumelia
8 years ago
3,605 posts
Should I myself try the following first then, before asking for your help?..
I mean...if you say go ahead, I can try doing this:
Quote: Between adding it back to my skin index_activity, and the reference to it I've added back to my skin's index.tpl that I did with Douglas in the beginning of this thread



--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
michael
@michael
8 years ago
7,805 posts
Think this is good:
{jrCore_list module="jrAction" search1="action_module != jrFollower"  search3="action_original_item NOT_LIKE jrProfile:%" order_by="_item_id desc" pagebreak=50 page=$_post.p}
michael
@michael
8 years ago
7,805 posts
see if it looks right on your site now.
Strumelia
Strumelia
@strumelia
8 years ago
3,605 posts
Michael that seems to be working great! My test comments on other people's profile page comment walls did not show up just now on the main page timeline (though they properly do show up in my own profile page timeline)...but my comment on someone's audio clip showed up right away on the main page timeline.
That's awesome.
There's a stray bit of text left over though- see the number "1" randomly showing at the top left of my main page timeline feed. I looked for where I could remove it myself, but I don't see any orphaned "1" in the Index.tpl code...so if you don't want to go back in just let me know where I can remove it, if you would.

I see where you added your above code in my skin index.tpl ...and I see where you commented out the previous code. I can do the same now on my other site to fix the issue there identiacally... but I do need to know whether you did anything elsewhere aside from that index.tpl on my skin. Did you wind up doing any of the stuff you mentioned in your prior posts concerning either the "index_action.tpl" or "index_activity.tpl" ? Or is the ONLY fix I need to do on my other site involve just the above code you changed in my active skin index.tpl ? Thanks so much for helping me with this!


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

updated by @strumelia: 01/25/17 01:46:18PM
michael
@michael
8 years ago
7,805 posts
That was me identifying where I was. When working on a live site I often put:

{$_user._user_id}
into the template to make sure where I'm editing is where I think I'm editing. Then if i need to run a debug, I know the user Im editing as ( #1 ) and can add:
{if $_user._user_id == 1}
  {debug}
{/if}

So only I see the debug popup window.

That was the ONLY change i made. If I couldnt find something that worked, there, then I would have gone into the template and adjusted it in the row template.

Glad that worked, keeps things simple. :)
updated by @michael: 01/25/17 02:59:05PM
Strumelia
Strumelia
@strumelia
8 years ago
3,605 posts
Ok, yes I was wondering what that new "$_user..." bit was when I looked at your code.

Question about debugging: I understand about the user id=1 thing (I'm understanding that user #1 was you logged in as me/masteradmin, right?)...can you tell me in layman's terms how, after adding such a code to run a 'debug'- how I would then actually make the debug window 'pop up'? Pop up in what program? I do have FF browser Dev tools- (used to be firebug?) is that where you are doing the 'debug'...or in JR tools somewhere? How do -I- make a debug window pop up for example when I'm editing the code of my skin's index.tpl ? Does it popup right there with the template modify window open, or do I have to paste the template code into some other window to pull up debug info ? No need to try and explain if you are pressed for time. I plan to do a little googling of 'debug' use tomorrow on a tea break at some point...I have a feeling it might help me.

Michael thank you for getting this code back working for me again. And thanks to you too Doug!
I applied the fix over on my other site as well and tested it- working fine now on both sites.
I'll mark this thread solved and move back to my other remaining site issues I need to fix tomorrow.


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
michael
@michael
8 years ago
7,805 posts
Not used debug before? Its a useful tool

Docs: "{debug}"
https://www.jamroom.net/the-jamroom-network/documentation/jamroom-developers-guide/1477/debug

You put it into the template you're interested in, then open the page where that template is used. Firefox will sometimes ask "Do you want to allow popups from site.com?" you click YES and refresh the page.

Next time you will get an extra window with all of the variables that exist on the page. You enter the {$something} and that will output the corresponding value that is assigned to that variable.

What I did for your situation was I needed to figure out what structure of search1="??? ?? ????" would work to get rid of what you dont want.

So for that I went into the database and looked at what was stored under the jr_jraction_item_value table and just figured out what things were unique to the timeline entries that you didnt want, and used that to construct the jrCore_list call.
Strumelia
Strumelia
@strumelia
8 years ago
3,605 posts
Thanks Michael, it's all working great now on both my sites, and I'll do a little reading about 'debug' in the next few days. Maybe some of that info will stick in my head- you never know! ;)


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015