blog documentation FAQ followers forum marketplace services youtube

solved img_url broken after 5.1.33 update

The Jamroom Network » Forum » Jamroom Developers » Page » img_url broken after 5.1.33 update
SteveX
SteveX
@ultrajam
11 years ago
2,584 posts 
{$ujLifeStreams_img_url}
in a stylesheet now outputs
Quote: http://mysite.com/image/img/module/ujLifeStreams/linkedin.png
Before the update that image url was output as /image/img/lifestreams/linkedin.png


--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)
updated by @ultrajam: 05/01/14 11:18:15PM
michael
@michael
11 years ago
7,802 posts
Thats right.

Before the update the skins
{$jrNova_img_url}
outputted
http://mysite.com/image/img/skin/linkedin.png
and then went ahead and used the default image of whatever skin was set.

now
{$jrNova_img_url}
checks the jrNova skin and
{$jrSage_img_url}
checks the sage skin.

So its a bug fix.

during the bugfix, the modules got an extra bit of structure to match the skins URL structure.

That URL is correct to look for the linkedin.png image in the /ujLifeStreams/img/ folder.

update the core to the latest to get it working properly.
SteveX
SteveX
@ultrajam
11 years ago
2,584 posts
I just updated the core to the latest which is when it broke!

Its the module image url which broke, not the skin. And there is no directory at /image/img/module/ujLifeStreams/ - that directory would be /module/ujLifeStreams/img/


--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)
michael
@michael
11 years ago
7,802 posts
Its not a directory on the file system. Its a 'magic view' which is taken care of via the jrImage module.

What it allows for is the ACP to over-ride the default image provided by the module.
SteveX
SteveX
@ultrajam
11 years ago
2,584 posts
Line 603 of /modules/jrCore/lib/skin.php is now:
$_rp['{$' . $mod . '_img_url}'] = "{$url}/{$crl}/img/module/{$mod}";
It would need to be something more like:
$_rp['{$' . $mod . '_img_url}'] = "{$url}/{$crl}/img/{$_mods[$mod]['module_url']}";



--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)
brian
@brian
11 years ago
10,149 posts
This should be fixed now - it was my fault. There was an image module update that needed to go out with the 5.1.33 release yesterday and I did not do that - update to the latest image module I just pushed out and you should be fixed.

Sorry about that!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
SteveX
SteveX
@ultrajam
11 years ago
2,584 posts
Thanks Brian.

All fine with the Image update.


--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)
brian
@brian
11 years ago
10,149 posts
SteveX:
Thanks Brian.

All fine with the Image update.

Right on - glad to hear it.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

Tags