solved jrStore - css and js files missing

SteveX
SteveX
@ultrajam
11 years ago
2,584 posts
The current jrStore (1.0.2) uses css and js from jrFoxycart/contrib/ but the /contrib dir hasn't existed in the past 3 releases of jrFoxycart (last appeared in 1.2.0, via marketplace).

This is the code from sale_list.tpl in jrStore:
    {*for the sortable tables in the loaded div*}
    
        @import "{$jamroom_url}/modules/jrFoxyCart/contrib/DataTables-1.9.4/smoothness/jquery-ui-1.8.4.custom.css";
    
    
    



--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)

updated by @ultrajam: 08/06/14 06:48:28AM
SteveX
SteveX
@ultrajam
11 years ago
2,584 posts
Forum is deleting anything with a link tag or style tag when creating a new thread?
    {*for the sortable tables in the loaded div*}
    <style type="text/css" title="currentStyle">
        @import "{$jamroom_url}/modules/jrFoxyCart/contrib/DataTables-1.9.4/smoothness/jquery-ui-1.8.4.custom.css";
    </style>
    <link rel="stylesheet" href="{$jamroom_url}/modules/jrFoxyCart/contrib/DataTables-1.9.4/media/css/jquery.dataTables.css" media="screen"/>
    <script type="text/javascript" src="{$jamroom_url}/modules/jrFoxyCart/contrib/DataTables-1.9.4/media/js/jquery.dataTables.min.js"></script>



--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)

updated by @ultrajam: 06/24/14 02:48:06AM
brian
@brian
11 years ago
10,149 posts
argh.. not sure how this cross dependency came into play - I will check it out and get it fixed up.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
brian
@brian
11 years ago
10,149 posts
This should be fixed in in Merchandise Store 1.0.3 - let me know if you see any issues.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
SteveX
SteveX
@ultrajam
11 years ago
2,584 posts
Thanks Brian, looks fine now.


--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)
brian
@brian
11 years ago
10,149 posts
Thanks Steve!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
SteveX
SteveX
@ultrajam
11 years ago
2,584 posts
Just noticed a jrStore typo as well in email_new_sale_subject.tpl:
Congratulatons!


--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)
SteveX
SteveX
@ultrajam
11 years ago
2,584 posts
Also, (not 100% sure of this) but looks like jrStore should have a module requirement for jrComment (javascript errors due to scrollintoview).


--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)
SteveX
SteveX
@ultrajam
11 years ago
2,584 posts
Also, I dont think the store comments will be working correctly (I dont have any purchases on my system to test against).

The text areas in the comments forms are lacking name attributes - the field won't be serialized without that.

sale_communication.tpl and purchase_communication.tpl


--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)
brian
@brian
11 years ago
10,149 posts
Thanks Steve - I'm in the process overhauling this module as I've found several issues as well - hopefully have this all updated early this next week.

Sorry for the hassle!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
SteveX
SteveX
@ultrajam
11 years ago
2,584 posts
jrStore sale_list.tpl line 3:
<div class="block_content" style="font-size: 0.7em">

This can cause problems if you add any other content in the page apart from the data table (eg breadcrumbs etc).

Imo, better to move the inline style to the dataTables_wrapper css class
.dataTables_wrapper {
  font-size: 0.7em;
}



--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)

Tags