blog documentation FAQ followers forum marketplace services youtube

Add ICO for Images

The Jamroom Network » Forum » Installation and Configuration » Page » Add ICO for Images
Dazed
Dazed
@dazed
12 years ago
1,022 posts
I am trying to change the favicon.ico and I am receiving the below error:

Invalid image type for favicon.ico - only JPG, PNG and GIF images are allowed -

How to repro:

go to site_url/core/admin/images
change favicon.ico image
click save

result: error occurs
updated by @dazed: 01/21/14 10:55:45PM
brian
@brian
12 years ago
10,149 posts
Yep - we have a ticket open on this and I'll have fixes in 5.1.7 that get this working (it doesn't even work right if you're able to upload it).

For now, just put your favicon.ico in your JR root and you should be good.

Hope this helps!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
MAD
MAD
@madc
12 years ago
600 posts
At the moment I think you have to replace it manually.

It is in the issue tracker
https://www.jamroom.net/the-jamroom-network/tracker/244/faviconico-make-sure-it-can-be-replaced
And here
https://www.jamroom.net/the-jamroom-network/forum/design-and-skin-customization/3282/favicon

So for now the only fix I found was to upload your favicon in your root directory ( Although I don't think that's read ) and also in the latest core update directory on your server which at this stage
is modules/jrCore-release-5.1.6/img ( which from testing, it reads it from here)

EDIT : Sorry @brian but I must have typed to slow lol
But the favicon still doesn't show when placed in root . It only shows when you have a copy in the latest update directory ( for me anyway )


--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
updated by @madc: 12/21/13 08:14:34AM
Dazed
Dazed
@dazed
12 years ago
1,022 posts
Thanks Brian. I a seem to be having issues or there are bugs. I have replaced the default image for multiple modules and whenever I upgrade, we seem to revert back to the default images for those modules. Since we are setting a new active image, it would be nice if that always remained in place.

Ba9801 make sure you refresh your image cache.
updated by @dazed: 12/21/13 08:17:37AM
brian
@brian
12 years ago
10,149 posts
Hmm - definitely should not be reverting, as the image info is stored in the DB and is only ever changed when modifying (or uploading) via the "image" tab for a module or skin.

Is there a specific module or skin you see the issue with? I can check it out.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Dazed
Dazed
@dazed
12 years ago
1,022 posts
JrImage and JrUser. I looked in the images and they still showed active but all of the skin images were changed to the jr default.
brian
@brian
12 years ago
10,149 posts
There's only 1 image in jrImage - "default.png" - is that the one you are changing? And when does it revert? When you upgrade the core or the jrImage module?

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
brian
@brian
12 years ago
10,149 posts
Just an update that there is currently an .htaccess rewrite rule that rewrites the favicon.ico to point to jrCore/img/favicon.ico - that's why it needs to be there.

I'll be updating that rule for Core 5.1.7.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Dazed
Dazed
@dazed
12 years ago
1,022 posts
Yes I have changed all the default jr images. I originally did it with the acp but after every upgrade it would show the jr default. I ended up just overwriting the default.png images in the actual module. After several upgrades though it gets a little tedious hehe.

It seems to be happening when the module is updated.
MAD
MAD
@madc
12 years ago
600 posts
Dazed:
Ba9801 make sure you refresh your image cache.
Always Do!
I actually dump it server side/
My fix is the only one that works for me


--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
updated by @madc: 12/21/13 08:37:40AM
MAD
MAD
@madc
12 years ago
600 posts
Dazed:
Yes I have changed all the default jr images. I originally did it with the acp but after every upgrade it would show the jr default. I ended up just overwriting the default.png images in the actual module. After several upgrades though it gets a little tedious hehe.

It seems to be happening when the module is updated.

No need to do this @dazed
Just use the same names for now ( EXACTLY ) and upload them to your skin directory ( ie. skins/jrNova/img)
That will override them


--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
updated by @madc: 12/21/13 08:42:37AM
Dazed
Dazed
@dazed
12 years ago
1,022 posts
BA no what I am trying to accomplish is that once you have overwritten the default image in the ACP, regardless of any update to the module, the new active image should be displayed not the image within the module. This is written in the db so it should call that one and not a call to the directory.
updated by @dazed: 12/21/13 08:49:14AM
MAD
MAD
@madc
12 years ago
600 posts
Yes but thats not working
https://www.jamroom.net/the-jamroom-network/tracker/254/button-player-image-needs-to-be-changeable-via-the-acp
As I said for now just do the above. It works I have 2 sites that it works on.
Otherwise you have another problem?
Basically it's a known fact that the ACP replacement images aren't working for some reason
read this : https://www.jamroom.net/the-jamroom-network/forum/design-and-skin-customization/3831/module-image-replacement-in-acp



--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
updated by @madc: 12/21/13 08:54:42AM
Dazed
Dazed
@dazed
12 years ago
1,022 posts
ok I am following you now.