investigating not an action_text activity error

soaringeagle
@soaringeagle
9 years ago
3,304 posts
when viewing pending items (timelines) and clicking the timeline item link to view the pending timeline i get this error see screenshot
actiontext.jpg
actiontext.jpg  •  320KB




--
soaringeagle
head dreadhead at dreadlocks site
glider pilot student and member/volunteer coordinator with freedoms wings international soaring for people with disabilities

updated by @soaringeagle: 10/21/16 03:11:41AM
brian
@brian
9 years ago
10,148 posts
This isn't a very helpful error message - I'll get that fixed up. What this means is the timeline entry is NOT modifiable, since it's not an action entry where the user typed it in - it's a timeline entry that was added by a module (i.e. "so and so just posted a new song", etc.).

The default in pending is to link to the "update" view, and sine automatic timeline entries have no update view you see this error.

I think we'll need to add a custom pending items setup in for timeline entries, as well as update the error message so it's more helpful - we'll check that out.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
soaringeagle
@soaringeagle
9 years ago
3,304 posts
why would a module timeline entry need approval and not just 1 manually added?
i would think only those added by typing something in would need approval cause thats the only way to spam using the timeline


--
soaringeagle
head dreadhead at dreadlocks site
glider pilot student and member/volunteer coordinator with freedoms wings international soaring for people with disabilities
brian
@brian
9 years ago
10,148 posts
soaringeagle:
why would a module timeline entry need approval and not just 1 manually added?
i would think only those added by typing something in would need approval cause thats the only way to spam using the timeline

Because those actions are tied to other pending items (say a song) - doesn't make sense to show a "so and so just posted this song" timeline update if the song is not approved.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
soaringeagle
@soaringeagle
9 years ago
3,304 posts
i figured the timeline action wouldnt even trigger untill the item was approved


--
soaringeagle
head dreadhead at dreadlocks site
glider pilot student and member/volunteer coordinator with freedoms wings international soaring for people with disabilities
brian
@brian
9 years ago
10,148 posts
No - it's created at the same time as the item is created (using an event trigger).


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

Tags