blog documentation FAQ followers forum marketplace services youtube

solved syntax error in new Ningja update?

The Jamroom Network » Forum » Design and Skin Customization » Page » syntax error in new Ningja update?
Strumelia
Strumelia
@strumelia
10 years ago
3,605 posts
Am trying to apply a part of the new Ningja header_menu_desktop.tpl update to my custom skin, and I get a message saying there is a syntax error. Can someone check this please?
I'm not sure, but maaaaaybe it's in this part:
                {if jrCore_module_is_active('jrSiteBuilder')}

                    {* User menu entries *}
                    {jrSiteBuilder_menu}

                {else}

                    <li{if isset($selected) && $selected == 'home'} class="menu_active"{/if}><a href="{$jamroom_url}">{jrCore_lang skin=$_conf.jrCore_active_skin id="1" default="Home"}</a></li>

                    {if jrCore_module_is_active('jrForum') && strlen($_conf.jrNingja_forum_profile) > 0}
                        <li{if isset($_post.option) && $_post.option == 'forum' && $_post._profile_id == '1'} class="menu_active"{/if}><a href="{$_conf.jrNingja_forum_profile}">{jrCore_lang skin=$_conf.jrCore_active_skin id="47" default="Forum"}</a></li>
                    {/if}
                    {if jrCore_module_is_active('jrGallery')}
                        <li{if isset($_post.module) && $_post.module == 'jrGallery'} class="menu_active"{/if}><a href="{$jamroom_url}/{jrCore_module_url module="jrGallery"}">{jrCore_lang skin=$_conf.jrCore_active_skin id="36" default="Images"}</a></li>
                    {/if}

thanks for checking. Wish I knew better how to find the syntax error, but I do know it's in my header_menu_desktop.tpl when I try to apply the new ningja update sections i want. =:-*

I also made copies of the new search and cart and menu icons from the new Ningja updated, and copied them into my server custom skin's Images folder, so now they work as well. Gotta bring over any images used in the new code updates. :)


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
updated by @strumelia: 05/22/15 05:05:54PM
brian
@brian
10 years ago
10,149 posts
You're missing the closing {/if} to that if/else - should be right above the check for the master user:

{/if}  <-- add this

{if jrUser_is_master()}



--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Strumelia
Strumelia
@strumelia
10 years ago
3,605 posts
Brian, while using "find" function...I'm not finding the word "master" nor the phrase "jrUser_is_master" at all, in the header_menu_desktop.tpl ...in either the new updated Ningja skin or in my custom skin.

Where is this location where I need to put the closing /if ? I don't see "jrUser_is_master" anywhere.


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
brian
@brian
10 years ago
10,149 posts
Strumelia:
Brian, while using "find" function...I'm not finding the word "master" nor the phrase "jrUser_is_master" at all, in the header_menu_desktop.tpl ...in either the new updated Ningja skin or in my custom skin.

Where is this location where I need to put the closing /if ? I don't see "jrUser_is_master" anywhere.

You absolutely should or your ACP link would be gone.

Are you doing this as a template edit in the online template editor or in the template file itself?


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Strumelia
Strumelia
@strumelia
10 years ago
3,605 posts
I am doing Compares via my ACP skin "modify/compare" function.

I don't know whether the syntax error is in the new updated Ningja skin's header_menu_desktop.tpl, or in my own active custom skin's header_menu_desktop.tpl.

I'm trying to apply the new ningja updates for the site builder support in its header_menu_desktop.tpl to my active custom skin. ...WITHOUT messing up all my custom header menu modifications.
No I am not doing this directly in the server. I already updated the Ningja skin today, then I was picking out a few things from it to apply to my custom active skin. Then i was going to clone that custom skin afterwards, and set the new clone as the active skin. But I got the syntax error message.
FWIW my ACP link is still there so far... =8-o

Hmm...I could put in the /if needed....if i could find where the 'master user check' is like you suggested. But not finding anything to do with master user in my headermenudesktop templates.



--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
updated by @strumelia: 04/20/15 12:45:06PM
brian
@brian
10 years ago
10,149 posts
Strumelia:
I am doing Compares via my ACP skin "modify/compare" function.

I don't know whether the syntax error is in the new updated Ningja skin's header_menu_desktop.tpl, or in my own active custom skin's header_menu_desktop.tpl.

It's in the one you are trying to update - there's no error in the one that is part of the NingJa release.

Quote:
I'm trying to apply the new ningja updates for the site builder support in its header_menu_desktop.tpl to my active custom skin. ...WITHOUT messing up all my custom header menu modifications.
No I am not doing this directly in the server. I already updated the Ningja skin today, then I was picking out a few things from it to apply to my custom active skin. Then i was going to clone that custom skin afterwards, and set the new clone as the active skin. But I got the syntax error message.
FWIW my ACP link is still there so far... =8-o

Hmm...I could put in the /if needed....if i could find where the 'master user check' is like you suggested. But not finding anything to do with master user in my headermenudesktop templates.

OK just to be sure - you are modifying your CUSTOM header_menu_desktop.tpl file in the "Template Editor" in your ACP - NOT in the skins/CustomSkin/header_menu_desktop.tpl file.. correct?

I will add the fix in for you = it will only take me a few seconds to do in your end for you.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
updated by @brian: 04/20/15 12:49:09PM
brian
@brian
10 years ago
10,149 posts
I've modified this for you - you should be set.

You'll see the jrUser_is_master() function call is on line 89 of the header_menu_desktop.tpl file.

Hope this helps!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Strumelia
Strumelia
@strumelia
10 years ago
3,605 posts
Yes, I see where you did it- Thank You! Now I can stop fussing nervously with it!

(and did you see how I successfully applied the other little updates to my custom skin?...without blowing up the planet this time?) l o l o l o l


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
brian
@brian
10 years ago
10,149 posts
Right on - glad I could help, and glad you go the other changes applied.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net