blog documentation FAQ followers forum marketplace services youtube

Bootstrap Skin

The Jamroom Network » Forum » Design and Skin Customization » Page » Bootstrap Skin
Developer Networks
Developer Networks
@developer-networks
10 years ago
566 posts
Working on a skin built on twitter bootstrap for Jamroom the last couple of days.

Seems the integrity check runs and after it finishes green I cant click on ok its hanging there.

Also the audio songs are not playing or showing up on the artist albums song list. However when I view it on a mobile device this dosent happen and all functions as normal.
updated by @developer-networks: 04/26/14 05:40:17PM
brian
@brian
10 years ago
10,148 posts
If you are developing, you should be using Firebug (or the built in developer tools for your browser) - this will point out the JS issues you are seeing.

Hope this helps!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
michael
@michael
10 years ago
7,717 posts
There's a reason the bootstrap skin is on github and not available via the marketplace, its not supported.

It's a community thing. If you would like to use it and improve it, great. Fork it on github and get it working.

I'm also working on a skin based on bootstrap now, so will be updating my repo as I go.
Developer Networks
Developer Networks
@developer-networks
10 years ago
566 posts
@brian Yes I use Firefox and Firebug. Thank you for suggesting these they are excellent tools.

@michael
Its not really a Bootstrap Skin from get hub support issue.

Im having a problem with using Javascripts. When I include some of them the audio dosent work on the desktops and not really sure why.

It was more of a development question regarding audio not playing while designing a skin. Also it is effecting the integrity checks.

Having the same issue even if I use jrBlank skin 1.0.1

When I enable some JS needed for the skin it disables the Audio player.

Also congrats on your upcomming skin!

Thanks
updated by @developer-networks: 03/23/14 07:27:12AM
brian
@brian
10 years ago
10,148 posts
jrBlank does not have any JS with it, so that cannot be the cause. What are you "enabling" that is causing an issue?

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Developer Networks
Developer Networks
@developer-networks
10 years ago
566 posts
Its my menu system has a couple JS scripts that are needed. Even if i disable the menu system I also think the bootstrap JS for my template are causing this as well.
updated by @developer-networks: 03/23/14 08:02:34AM
brian
@brian
10 years ago
10,148 posts
Then those JS scripts are what are causing the issue. You will need to disable them 1 at a time until you find the culprit, then you need to go into that JS file and look for functions that may be named the same as what is being used in jPlayer, then try to fix it.

It's not a JR issue though - it's clearly an issue with your menu JS.

Hope this helps!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
updated by @brian: 03/23/14 08:02:23AM
Developer Networks
Developer Networks
@developer-networks
10 years ago
566 posts
Yea, ive been on it since last night => this morning

Its happening from multiple ones so im trying to track down why bootstrap does it and also why the menu system causes it. I would find it hard to believe both have the same function names but that is logical to be the case so ill check that out. Thanks
updated by @developer-networks: 03/23/14 08:08:19AM
michael
@michael
10 years ago
7,717 posts
This might or might not be related:

"Bootstrap clashes with SimpleModal"
https://github.com/twbs/bootstrap/issues/11834

Jamroom uses simplemodal for things like the integrity check lightbox looking thing.
Developer Networks
Developer Networks
@developer-networks
10 years ago
566 posts
Thanks Michael that is very relevant. That is where im at with it after today=>tonight. I have worked out all the kinks in the JS however the Integrity checks are not jumping past the green complete screen.

Ill look in to it tonight=>tomorrow and pass along an update if I resolve this.
Developer Networks
Developer Networks
@developer-networks
10 years ago
566 posts
Fixed it

Apply this code to your bootstrap.css file and the integrity check will work normal in Jamroom again.

.modal-backdrop  {
overflow-y:auto;
max-height:90%;
margin-top:-45%;
}
michael
@michael
10 years ago
7,717 posts
I added this code to my main css file:
#modal_window {
    position: absolute;
    z-index: 1200;
}
seams to do the same thing.

Either's fine, but if possible its nice to avoid changing bootstrap, so then you can get it delivered via a CDN rather than stored locally.

Tags