solved jrComment module bug after renaming a Module URL

iLoveHouseMusic
iLoveHouseMusic
@ilovehousemusic
10 years ago
517 posts
jrComments bug?

1. Comment on a item, for example a gallery image.
2. Rename the gallery module URL from "Gallery" to "Pics".
3. Browse to that same gallery item. Comment on the item again (after changing the URL).
4. Go to the Index page of JrMediaPro > Side bar > Comments listing. You'll see that comments linked prior to the URL update do not reflect the new URL.

I know it sounds confusing but...here's a video demonstration =)
http://www.youtube.com/watch?v=bvyYG9V-03s

updated by @ilovehousemusic: 03/29/14 07:15:25PM
SteveX
SteveX
@ultrajam
10 years ago
2,584 posts
You need to name your modues when setting up your site.

You have no need to rename your modules from day to day.

If you rename the module, it is like cloning the module: Donc, it is a different module.


--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)
iLoveHouseMusic
iLoveHouseMusic
@ilovehousemusic
10 years ago
517 posts
@StevenX. I am setting up my site. it has been in Maintenance mode for over 2 weeks while I work out the kinks w/ the new template. However, I see what you're getting at. I suppose I thought the module would update the URL across all areas - including comments that have been posted to it's items. A reasonable assumption.
updated by @ilovehousemusic: 02/24/14 06:17:44PM
paul
@paul
10 years ago
4,326 posts
Are you clearing caches after the rename?


--
Paul Asher - JR Developer and System Import Specialist
iLoveHouseMusic
iLoveHouseMusic
@ilovehousemusic
10 years ago
517 posts
@paul - It's in developer mode. But I can give that a run!
brian
@brian
10 years ago
10,148 posts
iLoveHouseMusic:
jrComments bug?

1. Comment on a item, for example a gallery image.
2. Rename the gallery module URL from "Gallery" to "Pics".
3. Browse to that same gallery item. Comment on the item again (after changing the URL).
4. Go to the Index page of JrMediaPro > Side bar > Comments listing. You'll see that comments linked prior to the URL update do not reflect the new URL.

I know it sounds confusing but...here's a video demonstration =)
http://www.youtube.com/watch?v=bvyYG9V-03s


Yeah that's correct - the "comment item url" is actually saved as part of the comment, so if you change it later then those URLs will be wrong. It was done this way because we wanted to avoid having to save all of the commented item information as part of the comment as well (since this would have really ballooned the size of the comment datastore), so this was a trade off that was made, since like SteveX pointed out - most likely you're going to setup your module URLs when setting things up, but then never change them again.

Hope this helps!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

updated by @brian: 02/25/14 07:55:00AM
iLoveHouseMusic
iLoveHouseMusic
@ilovehousemusic
10 years ago
517 posts
@Brian - thanks that's the answer it was looking for then - that this behaviour is by design. Makes total sense though. I just didn't know if it should update the URL (on old comments) or not.

You can close this out...

Tags