solved How to apply the jrcore_lang strings change from Ninja update to my custom skin?

I see in the new Ninja update:
Version 2.0.11:
- Change: Updated hardcoded text strings to jrCore_lang functions.
I have no trouble applying the OTHER new template updates in the update description (thanks for providing the template and css file names that contain changes), but this particular language core one has me stumped as to where do I go to see/copy/apply this update to my custom skin (which is a child of ninja). ?

I updated the Ninja skin my one site (siteB) and not my other (siteA)... so i could compare this specific language thing. I found the updated Ninja language tab on my updated site displays 98 items, but my non-updated site's same language tab only displays 55. (I do have SB module on my updated site but not my site A, which might explain a few of these language entries). I'm not sure if this larger number of language strings results from the update or if that has nothing to do with it.

My question is WHERE do I look to get this particular 'core lang string' update into my custom skin?
Thanks


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
updated by @strumelia: 11/29/18 10:38:55AM

There were a lot of templates in the Ninja skin that had hard coded text in them, they were in the following:

skins/jrNinja/404.tpl
skins/jrNinja/header_menu_desktop.tpl
skins/jrNinja/header_menu_mobile.tpl
skins/jrNinja/index.tpl
skins/jrNinja/item_list.tpl
skins/jrNinja/profile_index_image.tpl
skins/jrNinja/profile_index_music.tpl
skins/jrNinja/profile_index_video.tpl

Use your compare tool to see the changes.

Hope this helps!


--

Douglas Hackney
Jamroom Team - Designer/Developer/Support
FAQ-Docs-Help Videos

Ah, ok... so none of THOSE things require .css file changes then? That means I can make the updates to my custom skin via the ACP Compare Tool.
If that's correct, great! I'll get right on it, and thanks!


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
updated by @strumelia: 08/21/18 11:58:37AM

So... it looks to me like that those language changes really only apply to the Ninja skin and I decided I should probably not apply them to my custom skin anyway, since I had done some custom menu and link languages changes for my own site.

I DID apply to my custom skin the OTHER Ninja updates to: tablet_core.css, header.tpl, and slidebar.css that were described in the Ninja updates... but not the language string changes. I hope that was the good thing to do... nothing seems to have blown up, in any case. =:-o


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

One goal lately has been to make sure all language strings are in the language file. You understand that you can change your languages from the templates too, so any updates related to language strings are not going to be an issue for you.

Good to have that reassurance, thanks Michael.
Marking this solved.


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

I have cloned Ninja skin and I added the changes in templates, do I need to do something for the new language strings to appear in the ACP > Skins > NinjaClone > Language ?

Still seeing only 60 strings in there when the Ninja skin got 98.

Here is an example of what those changes are: (screenshot)

If you've updated your cloned skin to also used the language file, then yes, you'll need to copy the extra items over to the /skins/yourskin/lang/en-us.php

But if you're not using any language other than english I would be tempted to go the exact opposite way and replace all the language file entries with their actual string and ignore the LANGUAGE tab all together.

Thanks for infos, got it made.

I am using translated site, most of those new strings won't matter, but for some reason the "ACP" text in menu was disappearing (and not using the default value), but all good after I got the translations in the strings added made.

After adding new language strings to your skins language file, you'll want to run the Integrity Check tool in order for those strings to be added to the skins language tab.

Hope this helps!


--

Douglas Hackney
Jamroom Team - Designer/Developer/Support
FAQ-Docs-Help Videos