blog documentation FAQ followers forum marketplace services youtube

solved Artists By Rating - jrRating Module

The Jamroom Network » Forum » Design and Skin Customization » Page » Artists By Rating - jrRating Module
MAD
MAD
@madc
11 years ago
600 posts
Nova Skin
I want to be able to add a tab to the section with the three tabs

Newest Artists
Artists By Name
Top Artists

I want to add another tab called : Artists By Rating

Is there any documentation on how to add a tab there pulling info from this module?


--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
updated by @madc: 02/05/14 10:12:39PM
paul
@paul
11 years ago
4,326 posts
Dependent upon the skin you're using, its maybe all in the artist.tpl template.
Adding another tab is likely as easy as adding another ul/li structure with an appropriate option in the URL call. The smarty code can then check for the option and do a jrCore_list with order_by profile_rating_count or profile_rating_average_count
hth
Pa


--
Paul Asher - JR Developer and System Import Specialist
updated by @paul: 12/22/13 09:59:47PM
MAD
MAD
@madc
11 years ago
600 posts
Thanks @paul that got me headed in the right direction.
I want to be able to Rate an Artists profile page.
So I added this to my profile_header.tpl

{jrCore_module_function function="jrRating_form" type="star" module="jrProfile" index="1" item_id=$item._item_id current=$item.profile_rating_1_average_count|default:0 votes=$item.profile_rating_1_count|default:0 }
It returns this when viewing a profile page.

jrRating_form: item_id not set correctly

-----------------------------------------------
<a name="kev"></a>
I have the added tab etc set, but it's not reading the item_id
I added to the artists.tpl eg.

        {assign var="rateclass" value="p_choice_active"}
        {assign var="order_by" value="profile_rating_1_average_count NUMERICAL_DESC"}
and
    <div class="{$rateclass}" onclick="window.location='{$jamroom_url}/artists/by_ratings'">Artists&nbsp;By&nbsp;Rating</div>

So the tab is there , is clickable etc but on load is empty ( of course as item_id can't be found and no profiles have been rated yet )

So back to the first thing as its not going to return something that it either can't find or has no value yet
So what am I missing?


--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
updated by @madc: 12/27/13 12:05:54PM
paul
@paul
11 years ago
4,326 posts
Put in a {debug} to see what variables you actually have.
I guess that as its a profile page there isn't an $item array and you need to do item_id=$_profile_id in the rating call.


--
Paul Asher - JR Developer and System Import Specialist
MAD
MAD
@madc
11 years ago
600 posts
Hi @paul, Getting there.
I changed to this in artists_row.tpl
{jrCore_module_function function="jrRating_form" type="star" module="jrProfile" index="1" item_id=$item._profile_id current=$item._profile_rating_1_average_count|default:0 votes=$item.profile_rating_1_count|default:0 }

It is working although the data isn't storing right
Attached is a screenshot of my data browser
It looks like the info is getting separated.
And from this php notice in php error log it looks like its looking for the title?

<span class="php_Notice">[24-Dec-2013 00:19:22 Europe/Dublin] PHP Notice: Undefined index: _item_id in /home/punkbp/public_html/addonsites/jr/modules/jrRating-release-1.1.0/include.php on line 156 [x 2]

<span class="php_Notice">[24-Dec-2013 00:19:22 Europe/Dublin] PHP Notice: Undefined index: in /home/punkbp/public_html/addonsites/jr/modules/jrRating-release-1.1.0/include.php on line 156 [x 2]

<span class="php_Notice">[24-Dec-2013 00:19:22 Europe/Dublin] PHP Notice: Undefined index: _item_id in /home/punkbp/public_html/addonsites/jr/modules/jrCore/index.php on line 7310 [x 2]

<span class="php_Notice">[24-Dec-2013 00:20:21 Europe/Dublin] PHP Notice: Undefined index: profile_title in /home/punkbp/public_html/addonsites/jr/modules/jrRating-release-1.1.0/index.php on line 129 [x 1]

Any thoughts?
PS How do I get the $item_id array into the pages I want to run the ratings on
Is there a Tute somewhere to bring them in?


--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
updated by @madc: 12/27/13 12:23:14PM
MAD
MAD
@madc
11 years ago
600 posts
Quote: Any thoughts?
PS How do I get the $item_id array into the pages I want to run the ratings on
Is there a Tute somewhere to bring them in?

Still waiting for this as it stuffs up my DB ?
I have tried a lot of different things but it still comes up without the data for the profile you are rating ie Data is in another field as the image above shows


--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
brian
@brian
11 years ago
10,148 posts
This:

{jrCore_module_function function="jrRating_form" type="star" module="jrProfile" index="1" item_id=$item._item_id current=$item.profile_rating_1_average_count|default:0 votes=$item.profile_rating_1_count|default:0 }

needs to be this:

{jrCore_module_function function="jrRating_form" type="star" module="jrProfile" index="1" item_id=$_profile_id current=$profile_rating_1_average_count|default:0 votes=$profile_rating_1_count|default:0 }

When viewing a profile, there is no "item" - it's just the direct $profile variables.

Let me know if that helps.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
MAD
MAD
@madc
11 years ago
600 posts
ahh ok so lose the item_
item_id=$item._profile_id
and make it
item_id=$_profile_id
?

Still trying to get my head around this stuff. Thanks @brian and @paul!


--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
brian
@brian
11 years ago
10,148 posts
Yep...


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
MAD
MAD
@madc
11 years ago
600 posts
This code was visible and clickable but threw the same error
I added this to my profile_header.tpl

{jrCore_module_function function="jrRating_form" type="star" module="jrProfile" index="1" item_id=$_profile_id current=$profile_rating_1_average_count|default:0 votes=$profile_rating_1_count|default:0 }

Still won't work.
Still the same result.

It's like the data has split up
I went in and added the code and also went into song by rating and I added a new rating for testing purposes.
You can clearly see the song one went in fine
( TOP OF SCREENSHOT #10 )
as it only has one file to delete or modify

the other is my edit with a rating applied but it is separating the info with 2 sections to delete.

If i try to delete the Data section it says invalid id
if I delete the rating section of #9 the lot goes

Also the data is absolutely wrong
You can see in the screenshot at first was posted by user ID 5 then the next one is user id 74 which is the profile I am trying to rate I am assuming.

I love the way you guys have the audio,concert and video rating.
How do I get that to work correctly with actually rating a band?
As that is most important with us.


--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
updated by @madc: 12/27/13 10:49:38AM
brian
@brian
11 years ago
10,148 posts
It should work - it was designed to rate items, but I think it should work with a profile as well. I will have to test here and see if I can spot a problem with it that is keeping it from working with just the profile.

I'll get to this as soon as I can - I've got a couple priority tickets I'm working on and then I'll try to see what's up.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
MAD
MAD
@madc
11 years ago
600 posts
NP @brian i have set up your ftp details to work with the new subdomain if need be :D
(ps when you have time )
I started from scratch at another sub as things weren't working correctly
So the ftp details you have NOW will get you into the new section


--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
updated by @madc: 12/27/13 12:25:18PM
brian
@brian
11 years ago
10,148 posts
I just tested this here in Elastic, and it is working using the code I posted above:

{jrCore_module_function function="jrRating_form" type="star" module="jrProfile" index="1" item_id=$_profile_id current=$profile_rating_1_average_count|default:0 votes=$profile_rating_1_count|default:0}

What template are you putting the code in?

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
MAD
MAD
@madc
11 years ago
600 posts
Nova Cloned ( Only css edited )
ps. It works, shows fine on the profile etc
thats why I pointed you at the data browser of the rating module which isn't storing correctly

It seems to be working but in the Databrowser it is not showing some fields ie title etc
I am getting these errors in the php error log ( or notices )

<span class="php_Warning">[26-Dec-2013 08:41:28 Europe/Dublin] PHP Warning: json_encode() [<a href='function.json-encode'>function.json-encode</a>]: Invalid UTF-8 sequence in argument in /home/punkbp/public_html/addonsites/jr/modules/jrCore-release-5.1.6/lib/misc.php on line 164 [x 6]

<span class="php_Warning">[26-Dec-2013 12:54:15 Europe/Dublin] PHP Warning: strlen() expects parameter 1 to be string, array given in /home/punkbp/public_html/addonsites/jr/modules/jrCore-release-5.1.6/lib/datastore.php on line 416 [x 5]

<span class="php_Notice">[26-Dec-2013 12:55:52 Europe/Dublin] PHP Notice: Undefined index: section in /home/punkbp/public_html/addonsites/jr/modules/jrCore-release-5.1.6/lib/page.php on line 1600 [x 3]

<span class="php_Notice">[26-Dec-2013 15:00:38 Europe/Dublin] PHP Notice: Undefined index: _item_id in /home/punkbp/public_html/addonsites/jr/modules/jrRating-release-1.1.0/include.php on line 156 [x 33]

<span class="php_Notice">[26-Dec-2013 15:00:38 Europe/Dublin] PHP Notice: Undefined index: in /home/punkbp/public_html/addonsites/jr/modules/jrRating-release-1.1.0/include.php on line 156 [x 33]

<span class="php_Notice">[26-Dec-2013 15:00:38 Europe/Dublin] PHP Notice: Undefined index: _item_id in /home/punkbp/public_html/addonsites/jr/modules/jrCore-release-5.1.6/index.php on line 7310 [x 1]

<span class="php_Warning">[27-Dec-2013 16:14:28 Europe/Dublin] PHP Warning: strlen() expects parameter 1 to be string, array given in /home/punkbp/public_html/addonsites/jr/modules/jrCore-release-5.1.7/lib/datastore.php on line 416 [x 2]

<span class="php_Fatal">[27-Dec-2013 18:12:51 Europe/Dublin] PHP Fatal error: Uncaught --> Smarty Compiler: Syntax error in template "/home/punkbp/public_html/addonsites/jr/data/cache/jrCore/c45c68670be4d772a88dd55f7fcd7749.tpl" on line 11 "{jrCore_module_function function="jrRating_form" type="star" module="jrProfile" index="1" item_id=$._profile_id current=$profile_rating_1_average_count|default:0 votes=$profile_rating_1_count|default:0 }" - Unexpected ".", expected one of: "{" , "identifier" <-- [x 1]

<span class="php_line"> thrown in /home/punkbp/public_html/addonsites/jr/modules/jrCore-release-5.1.7/contrib/smarty/libs/sysplugins/smarty_internal_templatecompilerbase.php on line 11 [x 1]

<span class="php_Notice">[27-Dec-2013 18:13:21 Europe/Dublin] PHP Notice: Undefined index: profile_title in /home/punkbp/public_html/addonsites/jr/modules/jrRating-release-1.1.0/index.php on line 129 [x 10]

<span class="php_Notice">[27-Dec-2013 18:14:11 Europe/Dublin] PHP Notice: Undefined index: _item_id in /home/punkbp/public_html/addonsites/jr/modules/jrCore-release-5.1.7/index.php on line 7349 [x 20]

<span class="php_Warning">[27-Dec-2013 19:22:10 Europe/Dublin] PHP Warning: json_encode() [<a href='function.json-encode'>function.json-encode</a>]: Invalid UTF-8 sequence in argument in /home/punkbp/public_html/addonsites/jr/modules/jrCore-release-5.1.7/lib/misc.php on line 164 [x 7]



--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
updated by @madc: 12/27/13 11:27:27AM
brian
@brian
11 years ago
10,148 posts
Those are only Notices (the fatal is an error in one of your templates). I do see the "title" is not being set, but that's not used in the rating anyway.

If it shows and works correctly, what issue are you seeing?

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
MAD
MAD
@madc
11 years ago
600 posts
If I try to call the profile rating into a new tab as specified above, It won't as the data isn't being stored correctly and shows nothing.
It comes out in the timeline : Punkbandpromotions just rated ""
In other words empty
https://www.jamroom.net/the-jamroom-network/forum/design-and-skin-customization/3962/artists-by-rating-jrrating-module#kev
Also the title IS used in other ratings ( as pictured in the attachment above ) one from my edit and the other from the song page = they are both ratings
ie.
Works :- jrAudio rating_title = 01 Brought by a man with no tongue
My Edit :- jrProfile rating_title =




--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
updated by @madc: 12/27/13 12:27:20PM
brian
@brian
11 years ago
10,148 posts
Do you mean have an "artists by rating" tab? that sorting is done via the rating numbers, so I'm not sure how the title comes into play on that page, but yes - for actions I can see that being an issue. Let me get an update in that will properly get the profile name in as the title and get an update out.

Hope this helps!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
MAD
MAD
@madc
11 years ago
600 posts
Yeah I added a tab to the artists section.
We really need that as we have found if the user views songs that are rated high,
that doesn't mean the rest of their stuff is any good and ie the user is annoyed.
That's why we have always allowed rating of Artists in a whole for other users to say " Hey I liked that song but their other stuff is good as well".

Just showing you what we are getting back after a simple edit
( I have totally rebuilt this site recently as some updates weren't taking correctly, So I thought spend the time now so I won't need to in future ;) )
The tab is not on the new version but will be when we can sort it out.
For now its just a rating on their profile but I will be calling into the artists_row etc as you can understand.

Ppppps....why can't I quote here??
This has only happened since I subbed. Just worked out the timing


--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
updated by @madc: 12/27/13 12:53:09PM
brian
@brian
11 years ago
10,148 posts
I just pushed out version 1.1.1 of the ratings module that should properly get the profile name now as the title - let me know how that works.

Quoting should not be related to your quota - are you talking about the "quote" button on hover, or do you mean quote bbcode tags?

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
MAD
MAD
@madc
11 years ago
600 posts
Nah sorry @brian I meant right here at your forum.
I don't get the quote balloon like i used to
Have to do it all manually


--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
updated by @madc: 12/27/13 01:25:34PM
brian
@brian
11 years ago
10,148 posts
ba9801:
Nah sorry @brian I meant right here at your forum.
I don't get the quote balloon like i used to
Have to do it all manually

Your quota permissions are all correct, so I'm not sure why you wouldn't see it - can you try logging out and then back in to see if that fixes it? If not let me know and I'll have to dig deeper.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
brian
@brian
11 years ago
10,148 posts
Nevermind - it was a type in the template and I've fixed it - thanks for letting me know.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
MAD
MAD
@madc
11 years ago
600 posts
Yeah all back now.


--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
MAD
MAD
@madc
11 years ago
600 posts
Ok title is now showing in the datastore browser but the rating don't look the same as the other ones ( eg. song rating )
They still seem to be getting split.
See images below.

and now these are only notices but they are occurring whenever I rate a profile

<span class="php_Notice">[30-Dec-2013 00:48:26 Europe/Dublin] PHP Notice: Undefined index: in /home/punkbp/public_html/addonsites/jr/modules/jrRating-release-1.1.1/include.php on line 156 [x 29]

<span class="php_Notice">[30-Dec-2013 00:48:26 Europe/Dublin] PHP Notice: Undefined index: _item_id in /home/punkbp/public_html/addonsites/jr/modules/jrCore-release-5.1.9/index.php on line 7390 [x 18]
rating-1.jpg
rating-1.jpg  •  178KB




--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
updated by @madc: 12/30/13 03:02:52AM
brian
@brian
11 years ago
10,148 posts
I see this happening in the DS browser as well - although the data looks good in the DB. I'll get this fixed up, sorry for overlooking it.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
brian
@brian
11 years ago
10,148 posts
Okay this should be fixed up now in Item Ratings 1.1.2:

https://www.jamroom.net/the-jamroom-network/networkmarket/73/item-ratings?expanded_changelog=1

Let me know if that fixes it up for you.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
MAD
MAD
@madc
11 years ago
600 posts
Thanks @brian that worked. But still have a problem with the rating not showing up in my timeline.
Had @michael helping me today and we couldn't get the timeline to show the ACTIVITY.

I am using this code in the profile_header.tpl

               <div class="block">
                    <div class="block_content mt10">
                        <div style="padding-top:8px;min-height:48px;max-height:288px;overflow:auto;">
                            {jrUser_online_status profile_id=$_profile_id}
{jrCore_module_function function="jrRating_form" type="star" module="jrProfile" index="1" item_id=$_profile_id current=$profile_rating_1_average_count|default:0 votes=$profile_rating_1_count|default:0 }
                        </div>
                    </div>
                </div>



--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
brian
@brian
11 years ago
10,148 posts
Yeah I saw the code push Michael did last night, so that is what I pushed out this morning - I was under the impression that fixed it.

I'll check it out and see what's up.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
michael
@michael
11 years ago
7,717 posts
That fixed the link when the rating made it into the timeline, but it was a bit inconsistent with the rating showing up in the activity stream. Of about user profiles doing ratings 5 ratings, 1 showed up once.

Not sure why, ran out of time looking at it.
brian
@brian
10 years ago
10,148 posts
Rating profiles was never supported by the module, so it's going to take more changes than the tweaks we've tried making - I'll be working on it this week.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
brian
@brian
10 years ago
10,148 posts
I just uploaded new versions of both the Activity Stream and Item Ratings modules that should fix this up - update and let me know if that works for you. It's working here for me now.

Hope this helps!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
MAD
MAD
@madc
10 years ago
600 posts
Yes it seems to work now.
I have found another error I think.
If I go into my timeline as admin or as a test user account,
And try and share something with my followers by clicking Share This under the timeline post
It returns this
@two-two-79:
INVALID_MODULE
Rated item "" with

I checked a clean phperror log after that and this warning is there

<span class="php_Warning">[04-Jan-2014 10:46:01 Europe/Dublin] PHP Warning: strlen() expects parameter 1 to be string, array given in /home/punkbp/public_html/addonsites/jr/modules/jrCore-release-5.1.10/lib/datastore.php on line 416 [x 1]

So something is still wrong.

Also I have added my tab ( Artists by ratings ) to the artists.tpl file and edited the artists_row.tpl.

The code I have in the row is

{jrCore_module_function function="jrRating_form" type="star" module="jrProfile" index="1" item_id=$item._profile_id current=$item._profile_rating_1_average_count|default:0 votes=$item.profile_rating_1_count|default:0 }

The stars show are clickable.
When rating, upon refreshing the same page the ratings disappear.
The action does go into my timeline though.
But all the rating stars are blank on every tab in the artists menu section
I have added an image to show you
( Or just goto http://jr.punkbp.com/artists )




--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
updated by @madc: 01/04/14 04:00:27AM
brian
@brian
10 years ago
10,148 posts
Okay - I will try to replicate the share this issue here and see what I find.

Note that your list call code is wrong - this:

current=$item._profile_rating_1_average_count|default:0

Should be this:

current=$item.profile_rating_1_average_count|default:0

(no underscore).

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
MAD
MAD
@madc
10 years ago
600 posts
Yeah sorry @brian. You said that about 15 posts ago. Must have missed it on my rebuild.
Apologies for that.
Rating tab is all working fine now.

It's only the timeline issue now.


--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
brian
@brian
10 years ago
10,148 posts
When you click on the "share" link in the timeline, are you doing it as a normal user viewing the timeline, or an admin user?

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
MAD
MAD
@madc
10 years ago
600 posts
I tried both , Admin and a member ( test account )
It only happens with the artists profile rating actions that go into the timeline.
The rest are fine


--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
brian
@brian
10 years ago
10,148 posts
Okay thanks - I'll check it out.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
brian
@brian
10 years ago
10,148 posts
I just pushed out version 1.1.6 of the Activity Stream module that should fix this up - sharing of actions was not actually working correctly for actions that came from registered module actions (i.e. rating, creating an audio file, etc.).

Make sure and clear your caches after update as it includes some template and CSS updates.

Let me know if that looks better.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
MAD
MAD
@madc
10 years ago
600 posts
Yep all good now.

The only thing I can see for some reason is the search_drop.png ( After updating Activity Stream Module ) has disappeared again ( Nova Skin )
I just put it back in the img folder.


--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
douglas
@douglas
10 years ago
2,791 posts
ba9801:
Yep all good now.

The only thing I can see for some reason is the search_drop.png ( After updating Activity Stream Module ) has disappeared again ( Nova Skin )
I just put it back in the img folder.

This has actually been changed to use the {jrCore_icon icon="arrow-down" size="20"} instead of an image.


--

Douglas Hackney
Jamroom Team - Designer/Developer/Support
FAQ-Docs-Help Videos
updated by @douglas: 01/04/14 11:08:02PM
MAD
MAD
@madc
10 years ago
600 posts
Hmm.. Well it's not working on the Nova skin.
It is still looking for it at modules/jrAction/img/search_drop.png
I have to go into the jrAction folder and check the image is in each one ( old and new versions )
Then put it in there and it works
Ps. core and all modules are up to date


--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
updated by @madc: 01/05/14 12:45:34AM
douglas
@douglas
10 years ago
2,791 posts
Did you update your Nova skin?

The change was made in the skins/jrNova/profile_index.tpl template, not the modules.

Hope this helps,
Douglas


--

Douglas Hackney
Jamroom Team - Designer/Developer/Support
FAQ-Docs-Help Videos
MAD
MAD
@madc
10 years ago
600 posts
Ok thanks Douglas. Missed that edit with diff merge as I am using a cloned nova skin.
Was that in the changelog?


--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
douglas
@douglas
10 years ago
2,791 posts
No, that edit didn't make it into the changelog sorry.


--

Douglas Hackney
Jamroom Team - Designer/Developer/Support
FAQ-Docs-Help Videos
MAD
MAD
@madc
10 years ago
600 posts
Be good to know of the files that are changed.
Not so much the edits as most people can work them out with a file comparison.
But files that are changed in the skin in the changelog would be great.


--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
douglas
@douglas
10 years ago
2,791 posts
Yeah, I've started adding the files/templates that have been modified to the changelog for the skins, and most likely will continue to do that from here on out, but I don't do much of the work on the module files so that would be up to whoever updates the changelog file.


--

Douglas Hackney
Jamroom Team - Designer/Developer/Support
FAQ-Docs-Help Videos
MAD
MAD
@madc
10 years ago
600 posts
Modules are ok as they are modified and the skin is updated to cater for the mod updates at your end, correct?
So the modules that are updated should coincide in any skin update I assume.


--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
updated by @madc: 01/05/14 10:07:24AM
douglas
@douglas
10 years ago
2,791 posts
Not necessarily, some modules can be updated without having to modify skin templates. And since I don't do much work on the modules, I don't do much work on the templates for the modules.


--

Douglas Hackney
Jamroom Team - Designer/Developer/Support
FAQ-Docs-Help Videos
updated by @douglas: 01/05/14 10:12:26AM
MAD
MAD
@madc
10 years ago
600 posts
Ok No Probs. If I see anything I will post here then.
Did you get my private note about the contact form also?


--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
douglas
@douglas
10 years ago
2,791 posts
Yeah, I believe that has already been fixed.

Even though all of the html didn't come through in the PN, I'm guessing the URL was wrong on one of the links?


--

Douglas Hackney
Jamroom Team - Designer/Developer/Support
FAQ-Docs-Help Videos
MAD
MAD
@madc
10 years ago
600 posts
I sent it again. Only one link in it
https://www.jamroom.net/the-jamroom-network/forum/off-topic/1788/form-contact-us#r1855


--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
douglas
@douglas
10 years ago
2,791 posts
Your right, it isn't fixed.

I'll get that fixed.

Thanks!


--

Douglas Hackney
Jamroom Team - Designer/Developer/Support
FAQ-Docs-Help Videos

Tags