MAD
MAD
@madc
11 years ago
600 posts
Ok this may seem like a simple question, But up to 5.1.5 my favicon was working and when I went into my skin ( cloned Nova ) in 5.1.5 there was an added field in the Images Tab which right down the bottom has the JR favicon in there.
I thought ok i'll upload mine into there seeings as it changed yet I can't upload an .ico file.

Before 5.1.5 I just popped it into my directory but now even if I right click on the image in the above section and view the image in my browser it still shows the JR favicon at the url I already have uploaded "again" my favicon.

I have cleared my caches ( all , Manually ) and browser caches have all been reset.

So is this a new addition to 5.1.5 where you have to upload the favicon in the acp yet you can't upload .ico files.

The attached image is a that was then this now

ugh.jpg
ugh.jpg  •  9KB




--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion

updated by @madc: 01/26/14 06:11:12AM
brian
@brian
11 years ago
10,148 posts
Let me check this out - could be the .ico file type is not allowed. Note that I'd recommend that you still upload your favicon.icon to the root directory and ignore the one in the core images section.

Hope this helps!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
MAD
MAD
@madc
11 years ago
600 posts
Yeah it is in the root directory but it's not showing. Only the JR one
Cheers


--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
brian
@brian
11 years ago
10,148 posts
You might need to modify the meta.tpl file for your skin and remove the link to the root one, or upload yours over top of the one from jrCore.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
MAD
MAD
@madc
11 years ago
600 posts
Thanks @brian. I uploaded over the favicon at modules/jrCore-release-5.1.5/img
that has fixed it for now but updates will change it again.
I looked in my meta.tpl in my skin and can't see where it's getting called from?
Below is my meta.tpl

<!doctype html>
<html lang="{jrCore_lang module="_settings" id="lang" default="en"}" dir="{jrCore_lang module="_settings" id="direction" default="ltr"}">
<head>
{jrCore_lang  skin=$_conf.jrCore_active_skin id="1" assign="default_title"}
<title>{$page_title|default:"`$default_title`"} | {$_conf.jrCore_system_name}</title>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
{if isset($meta)}
{foreach from=$meta key="mname" item="mvalue"}
<meta name="{$mname}" content="{$mvalue}" />
{/foreach}
{/if}
<link rel="stylesheet" href="{jrCore_css_src}" media="screen" />
{if isset($css_href)}
{foreach from=$css_href item="_css"}
<link rel="stylesheet" href="{$_css.source}" media="{$_css.media|default:"screen"}" />
{/foreach}
{/if}
{if isset($css_embed)}
<style type="text/css">
{$css_embed}</style>
{/if}
{if isset($javascript_embed)}
<script type="text/javascript">
{$javascript_embed}</script>
{/if}
<script type="text/javascript" src="{jrCore_javascript_src}"></script>
{if isset($javascript_href)}
{foreach from=$javascript_href item="_js"}
<script type="{$_js.type|default:"text/javascript"}" src="{$_js.source}"></script>
{/foreach}
{/if}
{if isset($javascript_ready_function)}
<script type="text/javascript">
$(document).ready(function(){ldelim}
{$javascript_ready_function}return true;
{rdelim});
</script>
{/if}
<link href='http://fonts.googleapis.com/css?family=Waiting+for+the+Sunrise' rel='stylesheet' type='text/css'>
</head>

What do I need to remove?


--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
alt=
@serin
11 years ago
38 posts
same issue here. How did you make it change?
CAPER
CAPER
@caper
11 years ago
125 posts
same issue as well
MAD
MAD
@madc
11 years ago
600 posts
Quote: Thanks @brian. I uploaded over the favicon at modules/jrCore-release-5.1.5/img
Upload your favicon into that directory. But as I said any future updates will override it.


--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
michael
@michael
11 years ago
7,714 posts
Issue tracker created:
https://www.jamroom.net/the-jamroom-network/tracker/244/faviconico-make-sure-it-can-be-replaced

Seams like an issue that needs looking at.
brian
@brian
11 years ago
10,148 posts
Right now just upload your favicon.ico into your jamroom root directory - uploading it using the core image function is not going to work - we'll get something together to make it work though.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
brian
@brian
11 years ago
10,148 posts
I've just uploaded a brand new "Favicon Creator" module to the Marketplace:

https://www.jamroom.net/the-jamroom-network/networkmarket/109/favicon-creator

that should handle all your favicon needs.

Hope this helps!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
MAD
MAD
@madc
11 years ago
600 posts
That works fantastic @brian!

Also just a heads up.
[*]YOU CAN'T UPLOAD AN ORIGINAL ICO FILE

You have to upload an image ( ie. png,gif,jpg etc )
But whatever image you upload it will convert into the favicon

Hats off to the maker :D


--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion
brian
@brian
11 years ago
10,148 posts
Right on - the favicon setup it generates is pretty awesome - not only does it work in all browsers, but it also show a sharper image for users on retina displays, as well as special larger images for Windows 8 Tiles and Opera speed dial too :)


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
MAD
MAD
@madc
11 years ago
600 posts
Oh and one more thing
MAKE SURE YOU MAKE IT ACTIVE after uploading it!
upload/save then view the screen and tick the ACTIVE box and save again.
( that always throws me :) )


--
~ https://punkbandpromotions.com ~
Check us out for all your Punk/Alternative Music!
Check us out on Facebook:- https://facebook.com/PunkBandPromotion

updated by @madc: 12/26/13 10:52:50AM

Tags