in progress Home page content block not updating, bad URLs in Activity feed

Clay Gordon
Clay Gordon
@claygordon
9 years ago
733 posts
1) In the attached screen shot, the Activity Feed and Lastest Forum posts are out of sync.

There should be at least two entries above the top one in Latest Forum Posts - the Activity Feed posts on Flavored Chocolate and on Rapadura sugar.

2) The URLs in the Activity feed are broken - they have a #rNNNNN after them and generate 404 errors.

http://www.thechocolatelife.com/priscilla/forum/14627/flavored-chocolate-and-continuous-tempering-machines#r14629

These were working last night when I went to bed. Not working this morning. I have made no changed to template code in the last 24 hours.

I have done a full integrity check including repair database tables.


updated by @claygordon: 03/05/15 08:37:18AM
Clay Gordon
Clay Gordon
@claygordon
9 years ago
733 posts
Note - the URLs of the original posts are okay - but that does not explain why they are not in the Latest Forum Posts list - it's the URLs to the comments that generate 404s.

ALL of the comment URLs now generate 404 errors.
updated by @claygordon: 02/02/15 08:48:15AM
Clay Gordon
Clay Gordon
@claygordon
9 years ago
733 posts
Searching for something unique in the user comments datastore - rapadura does not appear. But it is there in site-wide search.
brian
@brian
9 years ago
10,148 posts
Is this on your profile or on your main site? I'm not sure why it would work yesterday but not today if something wasn't changed.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Clay Gordon
Clay Gordon
@claygordon
9 years ago
733 posts
This is in the site-wide forums.

I don't even know what I could do to change the URL this way.
updated by @claygordon: 02/02/15 11:36:32AM
brian
@brian
9 years ago
10,148 posts
So there we no system updates, and no template changes? Could a template that was active been deactivated? Also - anything on the URL after the # mark is a URL "fragment" and is not seen by the server but only by the client, so that will never cause a 404.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Clay Gordon
Clay Gordon
@claygordon
9 years ago
733 posts
Okay, so the stuff following the # is not the cause.

The problem is:

http://www.thechocolatelife.com/[b]david-menkes[b]/forum/14620/whole-bean-chocolate-raw-chocolate-etc-and-the-law

Should be:

http://www.thechocolatelife.com/[b]clay[/b]/forum/14620/whole-bean-chocolate-raw-chocolate-etc-and-the-law

Which might explain why it's not updating properly in Latest Forum Posts.

I don't know where (in what template) this URL is constructed so I don't know if I changed anything.

--- edited to add ---

I did revert to 1.6.4 of the activity timeline module and then reset the template cache but that did not solve the problem.
updated by @claygordon: 02/02/15 12:02:08PM
brian
@brian
9 years ago
10,148 posts
thechocolatelife:
Okay, so the stuff following the # is not the cause.

The problem is:

http://www.thechocolatelife.com/[b] david-menkes[b] /forum/14620/whole-bean-chocolate-raw-chocolate-etc-and-the-law

Should be:

http://www.thechocolatelife.com/[b] clay[/b] /forum/14620/whole-bean-chocolate-raw-chocolate-etc-and-the-law

Which might explain why it's not updating properly in Latest Forum Posts.

I don't know where (in what template) this URL is constructed so I don't know if I changed anything.

--- edited to add ---

I did revert to 1.6.4 of the activity timeline module and then reset the template cache but that did not solve the problem.

I don't think it has to do with the timeline module - are you only seeing these URLs bad in the timeline though? Or is it all over?

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Clay Gordon
Clay Gordon
@claygordon
9 years ago
733 posts
{* BEGIN ACTIVITY *}
<div class="col12 last">
  <div class="item blog-archive-header m10">
    <h2>{jrCore_lang skin=$_conf.jrCore_active_skin id="27" default="Activity"}</h2>
  </div>
  <div class="blog-index-text" style="{if !jrCore_is_mobile_device()}height:400px; font: 10px/12px; overflow-y:scroll; overflow-x:hidden;{/if}margin: 10px 10px 0 10px;padding-bottom: 10px;">
{jrCore_list module="jrAction" order_by="_item_id numerical_desc" template="index_activity.tpl" pagebreak=7 page=$_post.p}
  </div>
</div>
{* END ACTIVITY *}

index_activity.tpl has not been modified.
Clay Gordon
Clay Gordon
@claygordon
9 years ago
733 posts
Brian -

I went to the POSTS for a random user and those URLs are properly formed. I then went to search for one of the posters involved - David Menkes - in the site-wide search and I only return the profile, not any of the posts he's contributed to. I navigated manually to his posts and none of the URLs there are malformed.

Then I went to David's profile and viewed his timeline and the URLs there are malformed. So ... it's something in the comments module? I went there and the last file modify date is Jan 29 on item_list.tpl. I don't believe I could have overlooked this for three days.

index.tpl is showing a modify date for today but i made no modifications today.
brian
@brian
9 years ago
10,148 posts
Yep I see the bad URLs, so let me see if I can spot how those are getting created and I will let you know.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
brian
@brian
9 years ago
10,148 posts
OK I found the root cause of this and have a "temp" fix into your item_action.tpl file for the Forum module. I'll get it fixed in the next module update - at that time you'll want to reset the template to the latest module version.

Hope this helps!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Clay Gordon
Clay Gordon
@claygordon
9 years ago
733 posts
Brian -

Had I modified item_action before you made this fix? I keep a change log of the modules I work in and the dates but I don't have a log of changes I might have made here.
brian
@brian
9 years ago
10,148 posts
thechocolatelife:
Brian -

Had I modified item_action before you made this fix? I keep a change log of the modules I work in and the dates but I don't have a log of changes I might have made here.

No - it's not something you did - the item_action.tpl is wrong, but it could actually appear "correct" some times, so it was tricky to "see" the problem.

The real fix for it can't happen in the template so it will be in the next module update.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Clay Gordon
Clay Gordon
@claygordon
9 years ago
733 posts
Brian -

--- edited to add ---

Okay gotcha. I was writing the below when the above came in.

Not a 100% fix in the Activity timeline on the home page. This URL is still bad:

http://www.thechocolatelife.com/greg-gould/forum/14634/pate-de-fruit -- 404

When I swap out my name it expands to:

www.thechocolatelife.com/clay/forum/14634/pate-de-fruit
http://www.thechocolatelife.com/clay/forum/tech-help-tips-tricks-techniques/14634/pate-de-fruit

and the page displays properly.

There are two posts from Greg Gould that are bad, and going back, one from Priscilla that is also bad, can't see a pattern in the skips. Some but not all of the David Menkes ones appear to be fixed.
updated by @claygordon: 02/02/15 01:26:18PM
Clay Gordon
Clay Gordon
@claygordon
9 years ago
733 posts
On a related note, and I apologize for doubling up -

The Latest Forum Posts content block on the home page is now only showing posts I created.

It's not showing ones I add comments to and it's not showing posts created or updated by other people.

This was working properly yesterday. I know it was.
brian
@brian
9 years ago
10,148 posts
thechocolatelife:
On a related note, and I apologize for doubling up -

The Latest Forum Posts content block on the home page is now only showing posts I created.

It's not showing ones I add comments to and it's not showing posts created or updated by other people.

This was working properly yesterday. I know it was.

I did not modify anything else on your site besides the jrForum/templates/item_activity.tpl file. Are you sure something didn't get updated on your site overnight?


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Clay Gordon
Clay Gordon
@claygordon
9 years ago
733 posts
If something got updated, I did not do it.

These changes are in index.tpl? It's impossible to get a timestamp as updating any template file on a page updates the timestamps on all of them. Or at least it does in my system. I made footer.tpl inactive, saved changes, now all of the modified template files have the same modification timestamp.
Clay Gordon
Clay Gordon
@claygordon
9 years ago
733 posts
This is the line that selects what to display (in index.tpl):

{jrCore_list module="jrForum" search="forum_post_count > 0" order_by="forum_updated desc" 

I don't see anything restricting things to just me.
brian
@brian
9 years ago
10,148 posts
thechocolatelife:
These changes are in index.tpl? It's impossible to get a timestamp as updating any template file on a page updates the timestamps on all of them. Or at least it does in my system. I made footer.tpl inactive, saved changes, now all of the modified template files have the same modification timestamp.

Is this in your FTP client or in the Template Editor?

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Clay Gordon
Clay Gordon
@claygordon
9 years ago
733 posts
In the template editor.

That said, the timestamps looking at the files in the FTP client don't show changes from Jan 12! This is because changes to the skins are stored in the db, right?

Tags