solved Recently Rated Gif's not Shrinking in Profile Index...

Ken Rich
Ken Rich
@ken-rich
10 years ago
926 posts
I took a screenshot (attached). That should be self explanatory! If not - I rated a moving Gif image but it display's huge on the profile index page in recently rated. See it live here - http://indiegospel.net/ken-rich
Bug Image.JPG.jpg
Bug Image.JPG.jpg  •  102KB




--

Ken Rich
indiegospel.net

updated by @ken-rich: 02/28/15 09:04:57PM
brian
@brian
10 years ago
10,148 posts
Ahh - it's an animated GIF. Jamroom cannot resize an animated GIF at this time (although I do have it on my TODO to check out if it is possible).

I would recommend editing your profile_header.tpl and in the template for the "recently rated" just set a width= value on the image so the browser will at least resize it.

Hope this helps!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Ken Rich
Ken Rich
@ken-rich
10 years ago
926 posts
Hi Brian,

I guess if it's not possible to resize them, maybe you could "prune" animated GIFs out of that list somehow. I'll see if I can implement the width fix for now - thanks.


--

Ken Rich
indiegospel.net
brian
@brian
10 years ago
10,148 posts
It was easier to add support for animated GIFs to the core Image support, so I just pushed out a new release of the Image Support module (1.3.0) that will now resize animated GIFs - update and that should fix you up.

Hope this helps!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Ken Rich
Ken Rich
@ken-rich
10 years ago
926 posts
Hi Brian,

It actually appears to be the profile_sidebar.tpl that displays the recently rated. That's "included" in the profile_header.tpl

I tried adding a simple width="72" and a style="max-width:72px !important;" to what seems (at least to me) to be the appropriate line, but there was no effect with either.

{jrCore_list module="jrRating" profile_id=$_profile_id search1="rating_image_size > 0" order_by="_updated desc" style="max-width:72px !important;" limit="14" assign="rated"}

I'm afraid that exhausts my rather limited "bag of tricks" - what's next?


--

Ken Rich
indiegospel.net
Ken Rich
Ken Rich
@ken-rich
10 years ago
926 posts
brian:
It was easier to add support for animated GIFs to the core Image support, so I just pushed out a new release of the Image Support module (1.3.0) that will now resize animated GIFs - update and that should fix you up.Hope this helps!

Hi Brian,

The update doesn't seem to work. I cleared caches and ran integrity check but the issue remains. See it live here - http://indiegospel.net/ken-rich


--

Ken Rich
indiegospel.net
brian
@brian
10 years ago
10,148 posts
It looks correct to me from here - most likely your browser has cached the un-resized image - see my screenshot.

Hope this helps!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

updated by @brian: 01/24/15 12:39:11PM
Ken Rich
Ken Rich
@ken-rich
10 years ago
926 posts
Hi Brian,

DUH - ya I forgot to clear my browser cache.

However, now I am seeing this GIF flashing like crazy and it didn't do that before.

Ouch - it flashes in Chrome and Firefox - in IE it actually locks up the browser.

Is their any chance that is being caused by your update? Here's the pic...

http://indiegospel.net/karen-showell/gallery/6897/various-from-internet


--

Ken Rich
indiegospel.net

updated by @ken-rich: 01/24/15 01:24:23PM
brian
@brian
10 years ago
10,148 posts
Ken_Rich:
Hi Brian,

DUH - ya I forgot to clear my browser cache.

However, now I am seeing this GIF flashing like crazy and it didn't do that before.

Ouch - it flashes in Chrome and Firefox - in IE it actually locks up the browser.

Is their any chance that is being caused by your update? Here's the pic...

http://indiegospel.net/karen-showell/gallery/6897/various-from-internet

Yeah that is not pretty - I ran several test GIFs here and they are all fine, so it's something about that GIF. For now you'd probably want to remove it if it is locking up a browser. I'm not sure what I can do on this end - I'm guessing there are going to be GIFs that might not work right. When I get back to my dev system I will see if I can spot what is up with that specific image.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Ken Rich
Ken Rich
@ken-rich
10 years ago
926 posts
Hi Brian,

There were actually 5 GIF's in that folder and all were doing the same thing. I deleted them but have them on my harddrive if you need them for test purposes.


--

Ken Rich
indiegospel.net
brian
@brian
10 years ago
10,148 posts
Ken_Rich:
Hi Brian,

There were actually 5 GIF's in that folder and all were doing the same thing. I deleted them but have them on my harddrive if you need them for test purposes.

Yeah - actually that would be helpful since the ones I have here work. Can you zip them up and send them to me at support [at] jamroom [dot] net ?

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Ken Rich
Ken Rich
@ken-rich
10 years ago
926 posts
No problem - I'll dig them out now before I forget.


--

Ken Rich
indiegospel.net
brian
@brian
10 years ago
10,148 posts
I've just pushed out a new version of the Image Support module that should fix this up. I ended up having to bundle an ImageMagick binary (convert) with the image module, as all the PHP based libraries really could not do it right. ImageMagick can properly resize an animated GIF and ensure the "frame timing" is all kept intact, which is what was breaking on these images.

Update and see if that looks better. If you still see the old versions, reset your image cache: ACP -> Media -> Image Support -> Tools -> Reset Image Cache.

Hope this helps!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Ken Rich
Ken Rich
@ken-rich
10 years ago
926 posts
Thanks Brian - I'll try that ASAP.


--

Ken Rich
indiegospel.net
Ken Rich
Ken Rich
@ken-rich
10 years ago
926 posts
Hi Brian,

The flashing is gone but so are the pictures. Now they don't show at all - lol.

I cleared my browser cache and tried other browsers. I reset image cache - still they just show blank outlines where the pic is supposed to be.

Not sure what to tell you. I appreciate all the efforts on this one, but there still seems to be an issue.


--

Ken Rich
indiegospel.net
brian
@brian
10 years ago
10,148 posts
It took a me a while this morning to figure out why this as working for me but not for you, and it turns out the new "convert" binary I had included in the Image tools was relying on some underlying OS libraries for it's work. There's no way for me to "package" them all with the tool, so I've just released a new version that removes the tool and now will require the "convert" imagemagick binary be installed on the server by the admin.

So do this:

- Update to the latest Image Support module
- contact your admin and have them installed "imagemaick" (apt-get install imagemagick on Debian based distros, "yum install imagemagick" on redhat based)
- once that is done check your Server Check and make sure it is green
- reset image cache

That should work now.

Hope this helps!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Ken Rich
Ken Rich
@ken-rich
10 years ago
926 posts
Ah... OK I'll get on that ASAP. Thanks


--

Ken Rich
indiegospel.net
Ken Rich
Ken Rich
@ken-rich
10 years ago
926 posts
My server must have had the required files for this version because I simply did the update and it worked.

Mind you, displaying those gifs in a lightbox creates a few seconds lag time, I guess due to their size and whatever processing is required. Server is getting a speed increase soon, none too late.

I rated one and it showed up correctly sized in the side column as recently rated. All is well thanks.


--

Ken Rich
indiegospel.net
brian
@brian
10 years ago
10,148 posts
Ken_Rich:
My server must have had the required files for this version because I simply did the update and it worked.

Mind you, displaying those gifs in a lightbox creates a few seconds lag time, I guess due to their size and whatever processing is required. Server is getting a speed increase soon, none too late.

I rated one and it showed up correctly sized in the side column as recently rated. All is well thanks.

Glad to hear it. Yeah the resizing is going to be a bit slower since an animated GIF is really a bunch of GIF images stacked up, so each "frame" has to be resized, so it will take longer (and depends on the length of the animated GIF).


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net