completed jrImage_display crop=none ?

SteveX
SteveX
@ultrajam
11 years ago
2,584 posts
Everything image-wise is perfect, but there is one more thing...

I am passing a user choice of crop into a {jrCore_module_function function="jrImage_display" crop=$crop_choice ... and I'd like to offer a crop_choice of "no crop".

I can do this (of course) by duplicating the jrCore_module_function call in my templates surrounded by an "if $crop_choice == 'none' (run module function without crop parameter) else (run module function with crop parameter)". But it irks me to do that and it's the only way I can find to stop the crop=auto square from kicking in if no crop is desired.

Also, the user could select "width" or "height" (depending on the aspect ratio of their image) to get no crop. But that will add confusion, it's always difficult to explain an aspect ratio to an uninitiated user in a dropdown menu.

So unless I have missed something (very possible just after Christmas), I think I am asking for just one more additional crop parameter along these lines:
crop="none"
(Or for no error or crop to occur if crop="" in the jrCore_module_function call)

Reference to this thread:
https://www.jamroom.net/the-jamroom-network/forum/design-and-skin-customization/10456/image-sizes

Thanks :)




--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)

updated by @ultrajam: 01/28/15 11:25:23PM
brian
@brian
11 years ago
10,149 posts
Should be easy to add and would make things cleaner, so I've add this to my todo :)

Hope this helps!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
SteveX
SteveX
@ultrajam
11 years ago
2,584 posts
Thanks Brian :)


--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)
brian
@brian
11 years ago
10,149 posts
OK this is now supported in Image Support 1.2.5 - update and let me know if you see any issues.

Hope this helps!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

Tags