blog documentation FAQ followers forum marketplace services youtube

Timeline Comments

The Jamroom Network » Forum » Suggestions » Page » Timeline Comments
Developer Networks
Developer Networks
@developer-networks
11 years ago
566 posts
Just had a suggestion as I was just looking at the timelines. It would be nice like Steve said to make them a little longer on this site and also allow users who are following a person to comment on the activity post.


updated by @developer-networks: 12/17/13 01:17:14PM
paul
@paul
11 years ago
4,326 posts
You can add comments to jrAction item_list.tpl (or a copy of it - jrAction_item_list.tpl - in the skin folder) -

{jrComment_form module="jrAction" profile_id=$item._profile_id item_id=$item._item_id item=$item}

The problem is that posting a comment, in turn, creates another action, which will have a comment box, so you end up with comments on comments!!

It would likely need a small custom 'listener' module to filter out comment actions.


--
Paul Asher - JR Developer and System Import Specialist
brian
@brian
11 years ago
10,148 posts
I don't think it needs any listener - there's no problem with comments on action items, since every action item has it's own page, any comments on that page would be attached to that specific action item.

We also want to make sure and use the jrCore_module_features smarty function in any detail page - i.e.

{jrCore_item_detail_features module="jrAction" item=$item}

That way all registered item detail functions can be present (if wanted).


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
paul
@paul
11 years ago
4,326 posts
That's ok for a single comment form in the action details page, but was just thinking about if the comment form was put in the list loop. That's when things might get messy!!


--
Paul Asher - JR Developer and System Import Specialist
brian
@brian
11 years ago
10,148 posts
The comment form is an "item detail page" element, so doesn't appear in the lists, so I don't think we have to worry about that. Now if someone modifies the templates on their own and adds a comment form to the looped lists, then yeah it would be a mess :)


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
paul
@paul
11 years ago
4,326 posts
Yeah - but if anyone really wanted to do it, comment actions could be filtered out with a search parameter in the {jrCore_list module="jrAction" . . .} call.


--
Paul Asher - JR Developer and System Import Specialist
brian
@brian
11 years ago
10,148 posts
So now you'll see in the Timelines here on jamroom.net that there is a "Comments" link (along with the Share This link) for timeline entries now, so you can comment on timeline entries.

Let me know if you guys see any issues and if it is helpful :)

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
paul
@paul
11 years ago
4,326 posts
Just test commented on one of michael's actions in my timeline. The comment was accepted an showed in the action detail page, but on returning to the timeline, its not showing. Comments still say '0' on both my and michael's timeline.
Going back to the detail page and no comment.
Is it a cache thing?


--
Paul Asher - JR Developer and System Import Specialist
douglas
@douglas
11 years ago
2,791 posts
I see your comment and the comment count is 1 for me?


--

Douglas Hackney
Jamroom Team - Designer/Developer/Support
FAQ-Docs-Help Videos
paul
@paul
11 years ago
4,326 posts
Where are you seeing it (url)?


--
Paul Asher - JR Developer and System Import Specialist
updated by @paul: 11/16/13 07:43:42AM
brian
@brian
11 years ago
10,148 posts
paul:
Just test commented on one of michael's actions in my timeline. The comment was accepted an showed in the action detail page, but on returning to the timeline, its not showing. Comments still say '0' on both my and michael's timeline.
Going back to the detail page and no comment.
Is it a cache thing?

Yeah it's going to be a cache thing - with caching eventually all the numbers will line up.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
douglas
@douglas
11 years ago
2,791 posts
paul:
Where are you seeing it (url)?

https://www.jamroom.net/douglas


--

Douglas Hackney
Jamroom Team - Designer/Developer/Support
FAQ-Docs-Help Videos
paul
@paul
11 years ago
4,326 posts
Yep - Seeing them now.


--
Paul Asher - JR Developer and System Import Specialist
brian
@brian
11 years ago
10,148 posts
I've got a ticket open on getting the caching working better for action items:

https://www.jamroom.net/the-jamroom-network/tracker/146/improve-cache-invalidation-for-action-comments-and-shares

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

Tags