Forum Activity for @john-bizley

Please Critique My Site Before I move on further

Design and Skin Customization


Thanks Strumelia, glad you mentioned that sripe as it was a test for something but forgot to remove it but have done now.
No not using the site builder and the Skin is just the Ningja Skin. Mostly everything is just styling in css and a few little adjustments to some templates, I just do a little bit each day. Next is just to work on adding more to the main toolbar for lists like site blogs, forum etc. I have not shared much of how I did things on the forum but will do now I know how things works a lots better, didn't want to post any tips etc until I was confident things worked out ok.

Please Critique My Site Before I move on further

Design and Skin Customization

Well I think I have finished with the overall look. Next is to move onto adding more list modules to the menus to filter out the data etc. Just got to get the badges to also show to visitors as well.

http://1940snetwork.com/founder

How to get the badges to show for non members ?

Profile Badges

This is where I have the code in the profiles sidebar, the badge code I added under the members image so it shows below it. This is the very top portion of the code for the page.







{if jrProfile_is_profile_owner($_profile_id)}
{jrCore_module_url module="jrProfile" assign="purl"}
{jrCore_lang skin=$_conf.jrCore_active_skin id="7" default="Change Image" assign="hover"}
{jrCore_module_function function="jrImage_display" module="jrProfile" type="profile_image" item_id=$_profile_id size="xlarge" class="img_scale img_shadow" alt=$profile_name title=$hover width=false height=false}

{$hover} {jrCore_item_update_button module="jrProfile" view="settings/profile_id=`$_profile_id`" profile_id=$_profile_id item_id=$_profile_id title="Update Profile"}

{else}
{jrCore_module_function function="jrImage_display" module="jrProfile" type="profile_image" item_id=$_profile_id size="xlarge" class="img_scale img_shadow" alt=$profile_name width=false height=false}
{/if}



{* Badges Start *}

{if jrCore_module_is_active('myBadges') && $_user.quota_myBadges_allow_badges == "on"}

{* Member Badge *}
{if $quota_myBadges_badge_type == "member"}

updated by @john-bizley: 02/16/15 12:57:35PM

Photo Lightbox viewer possible to link to image ?

Design and Skin Customization


Yes that is correct Michael, from the lightbox click a link to open that image to comment on it.
You mentioned by clicking a link in the lightbox the image would open in another tab to comment on it.
My question to that was: When that image is opened in another tab would it be in that new tab on it's own with a comment section or would it be by opening a new tab which shows that persons profile page and the image on display to comment on ?

It makes a difference as the way it is viewed because two instances of the same network open can confuse some people and they might close the wrong tab by mistake. This is why I mentioned having the image display in a window like the licence info box when you click on the modules licence details.

So here is the actions: Go to a members photo gallery > select the lightbox option > click through the photos > stop on a photo you want to comment on > click a comment button (link) > screen opens with the image and comment wall > add comment close screen > continue browsing photos in lightbox.

I will see if I can make some sort of mock up image as an example of what I mean by the licence box idea.

Photo Lightbox viewer possible to link to image ?

Design and Skin Customization


Are we talking opening the whole network with the said photo in the large photo viewer section on it's page or just opening the image in another window with the comment section underneath it ?
Yes opening in another tab could work, as you say it is the easiest to implement. Do you think this way will work ok on a phone or tablet ?

How about something like this, click a comment button ( ie link ) then the image is displayed within it's own page but a smaller size image with the comment section below it. This will show on top of the lightbox so when you comment and close it the lightbox is still there. The way I see this is much like when we click on let's say the licence details of a module, a new screens comes up with the details of the licence for that module so instead of that it would be the image and comment section.

How to get the badges to show for non members ?

Profile Badges


Thanks will check that out.

Please Critique My Site Before I move on further

Design and Skin Customization

Made a few more changes after the feedback and it is coming along nicely, still a few more bits to do like the blogs at the bottom of the main page but everything is looking great so far.
Keep the input coming as it is very helpful
Thanks!

Photo Lightbox viewer possible to link to image ?

Design and Skin Customization

I like the way you can move through the photos in the lightbox viewer but there is one thing missing that would be a great addition and that is a direct link to the current image.

So if you like an image and want to comment on it if a link was there you would not then have to go back into the gallery to find the image then add the comment to it. One thing that would be really nice also is if you have done that then a button to return to the position in the lightbox would be excellent.

Maybe another way this could be done is to have a button on the lightbox which will open a comment box, so you add your comment and once done then continue moving through the images.

I am sure this would be possible to do. Any thoughts on this ?
updated by @john-bizley: 03/23/15 01:05:12AM

Please Critique My Site Before I move on further

Design and Skin Customization

@strumelia
Thankyou for writing that up Strumelia as it's very helpful. Yes the layout may look the same as it's just the standard Ningja layout as not used the sitebuilder to create the pages. I will be adding some links into the main nav menu once I get everything in place.
2) Good point about the blogs and will make that change.
3) Yes the blogs tend to outweigh the forums going by previous uses on my old Ning site but I do agree they look a little big on the homepage.
4) I did think my scrollbars where ther already so will check into that, thanks for pointing that out.
5) That pagination for the blogs I probably will remove as you are right on what you say.
6) Good point as the backgrounds do look a little bright, I may add some old paper texture to them so they look more like old type documents.
7) I may do the same and add some more rows to the photos on the homepage and I like your idea of limiting the uploads per day.
8) hmm I wonder why that is not showing the 'All' for the forum posts, will look into that.

Once again Strumelia what you have written has been very helpful indeed which is one reason I added this post as it's always good to get another person's perspective.

Maybe it would be an idea to have another category in the Jamroom forum for site critiques.

Thanks again
John

Please Critique My Site Before I move on further

Design and Skin Customization


Thanks Paul, I see what you mean about the footer will get that fixed up and also that spacing.
Thanks for taking the time to for taking a look.